Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text-input): update prop-type for invalidText, warnText #7430

Merged
merged 9 commits into from
Dec 17, 2020
Merged

fix(text-input): update prop-type for invalidText, warnText #7430

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2464ebe
fix(text-input): update type invalidText, warnText
epodgaetskiy Dec 10, 2020
e4c1c5b
fix(text-input): update snapshot
epodgaetskiy Dec 10, 2020
d0344bd
Merge branch 'master' into fix-text-input-update-type-invalidText
epodgaetskiy Dec 10, 2020
e030fdf
Merge branch 'master' into fix-text-input-update-type-invalidText
epodgaetskiy Dec 10, 2020
8c9b0c6
Merge branch 'master' into fix-text-input-update-type-invalidText
epodgaetskiy Dec 11, 2020
589f97d
Merge branch 'master' into fix-text-input-update-type-invalidText
epodgaetskiy Dec 15, 2020
aced43c
Merge branch 'master' into fix-text-input-update-type-invalidText
epodgaetskiy Dec 15, 2020
2ea6e2b
Merge branch 'master' into fix-text-input-update-type-invalidText
epodgaetskiy Dec 16, 2020
cbb7106
Merge branch 'master' into fix-text-input-update-type-invalidText
kodiakhq[bot] Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5319,7 +5319,7 @@ Map {
"type": "bool",
},
"invalidText": Object {
"type": "string",
"type": "node",
},
"labelText": Object {
"isRequired": true,
Expand Down Expand Up @@ -5427,7 +5427,7 @@ Map {
"type": "bool",
},
"invalidText": Object {
"type": "string",
"type": "node",
},
"labelText": Object {
"isRequired": true,
Expand Down Expand Up @@ -5538,7 +5538,7 @@ Map {
"type": "bool",
},
"invalidText": Object {
"type": "string",
"type": "node",
},
"labelText": Object {
"isRequired": true,
Expand Down Expand Up @@ -5585,7 +5585,7 @@ Map {
"type": "bool",
},
"warnText": Object {
"type": "string",
"type": "node",
},
},
"render": [Function],
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/TextInput/ControlledPasswordInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ ControlledPasswordInput.propTypes = {
/**
* Provide the text that is displayed when the control is in an invalid state
*/
invalidText: PropTypes.string,
invalidText: PropTypes.node,

/**
* Provide the text that will be read by a screen reader when visiting this
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/TextInput/PasswordInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ PasswordInput.propTypes = {
/**
* Provide the text that is displayed when the control is in an invalid state
*/
invalidText: PropTypes.string,
invalidText: PropTypes.node,

/**
* Provide the text that will be read by a screen reader when visiting this
Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/components/TextInput/TextInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ TextInput.propTypes = {
/**
* Provide the text that is displayed when the control is in an invalid state
*/
invalidText: PropTypes.string,
invalidText: PropTypes.node,

/**
* Provide the text that will be read by a screen reader when visiting this
Expand Down Expand Up @@ -262,7 +262,7 @@ TextInput.propTypes = {
/**
* Provide the text that is displayed when the control is in warning state
*/
warnText: PropTypes.string,
warnText: PropTypes.node,
};

TextInput.defaultProps = {
Expand Down