-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(text-input): update prop-type for invalidText, warnText #7430
fix(text-input): update prop-type for invalidText, warnText #7430
Conversation
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: cbb7106 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fdb7a0d639f7b0007572a1a 😎 Browse the preview: https://deploy-preview-7430--carbon-elements.netlify.app |
✔️ Deploy preview for carbon-components-react ready! 🔨 Explore the source changes: cbb7106 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5fdb7a0d791eeb00070d96c5 😎 Browse the preview: https://deploy-preview-7430--carbon-components-react.netlify.app |
@epodgaetskiy snapshots just need to be updated, please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@epodgaetskiy lgtm :)
This PR makes to change prop-type for
invalidText, warnText
ofTextInput
to support internationalization.The problem at example
Changelog
Changed
string
tonode
forinvalidText, warnText
ofTextInput
Testing / Reviewing