fix(Tooltip): prevent right click from triggering tooltip #7434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: a05fa42 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fd8d445a9b0d20007d7f6e3 😎 Browse the preview: https://deploy-preview-7434--carbon-elements.netlify.app |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit a05fa42 https://deploy-preview-7434--carbon-components-react.netlify.app |
joshblack
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7423
This PR modifies the
handleMousemethod to include right clicks and prevent the tooltip from opening when the trigger button is right clickedTesting / Reviewing
Confirm that the tooltips are not opened by right click events and that no behavioral regressions were introduced