fix(MultiSelect.Filterable): dynamically resize selection count #7446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
emyarod
requested review from
a team
and removed request for
johnbister and
a team
emyarod
requested review from
laurenmrice
and removed request for
johnbister
emyarod
changed the title
emyarod
force-pushed
the
4721-filterable-multiselect-dynamic-sizing
branch
from
c29d564
to
6428b8c
Compare
|
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: 42f94f4 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fd7c3c9cc735b0007504c38 😎 Browse the preview: https://deploy-preview-7446--carbon-elements.netlify.app |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 42f94f4 https://deploy-preview-7446--carbon-components-react.netlify.app |
dakahn
approved these changes
Dec 14, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4721
This PR removes the absolute positioning rule on the filterable multiselect selection count to prevent it from overlapping with the text input
Testing / Reviewing
Confirm that the filterable multiselect selection count is correctly spaced especially as the count grows