fix(Loading): remove extra padding on loading spinners #7447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: e5ed66e 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fd7a27ec3cdfe0009b6366a 😎 Browse the preview: https://deploy-preview-7447--carbon-elements.netlify.app |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit e5ed66e https://deploy-preview-7447--carbon-components-react.netlify.app |
aledavila
approved these changes
Dec 11, 2020
laurenmrice
approved these changes
Dec 14, 2020
tw15egan
approved these changes
Dec 14, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
joshblack
approved these changes
Dec 14, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6814
This PR removes the extra padding on our loading spinners so that it reflects the spec more accurately
Testing / Reviewing
Confirm the regular and small loading spinners more closely match the spec