fix(toast-notification): remove default value from optional caption prop #7901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 7b85334 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 7b85334 https://deploy-preview-7901--carbon-components-react.netlify.app |
joshblack
reviewed
Feb 25, 2021
|
Everything looks good code-wise, just want to get some design input if the padding is correct when there is no caption
|
tw15egan
requested review from
a team and
kingtraceyj
and removed request for
a team
jnm2377
approved these changes
Feb 25, 2021
tay1orjones
approved these changes
Mar 1, 2021
joshblack
approved these changes
Mar 1, 2021
kingtraceyj
requested changes
Mar 2, 2021
|
@kingtraceyj updated 👍 |
kingtraceyj
approved these changes
Mar 11, 2021
tw15egan
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the toast notification's component guidelines and the propTypes, the
captionprop (intended for timestamp) is optional. However, currently it defaults to "provide a caption" whicha) makes it seem to be required (as other component usually do this for missing, required props such as titles), and
b) require the developer to pass an empty caption to the component in order to remove it, which is unusual for an optional prop
Changelog
Removed
props.captioninToastNotificationTesting / Reviewing