Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(skeleton): update skeleton styles on Checkbox, CodeSnippet, ProgressIndicator, and TextArea #7973

Merged
merged 5 commits into from
Mar 6, 2021

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Mar 3, 2021

Closes #7969
Closes #7963
Closes #7971
Closes #7966

Updates skeleton styles for a few components.

Changelog

Changed

  • Adjusted spacing, selectors so Skeleton styles render correctly

Removed

  • Extra storybook content that is no longer relevant

Testing / Reviewing

Check the skeleton states for the following components

  • Checkbox
  • CodeSnippet
  • ProgressIndicator
  • CodeSnippet

@tw15egan tw15egan requested a review from a team as a code owner March 3, 2021 23:15
@tw15egan tw15egan changed the title Fix skeleton issues fix(skeleton): update skeleton styles Mar 3, 2021
@netlify
Copy link

netlify bot commented Mar 3, 2021

Deploy preview for carbon-elements ready!

Built with commit 8d80ba3

https://deploy-preview-7973--carbon-elements.netlify.app

@tw15egan tw15egan changed the title fix(skeleton): update skeleton styles fix(skeleton): update skeleton styles on a couple components Mar 3, 2021
@netlify
Copy link

netlify bot commented Mar 3, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 8d80ba3

https://deploy-preview-7973--carbon-components-react.netlify.app

@tw15egan tw15egan changed the title fix(skeleton): update skeleton styles on a couple components fix(skeleton): update skeleton styles on Checkbox, CodeSnippet, ProgressIndicator, and TextArea Mar 3, 2021
Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 💯 LGTM

@kodiakhq kodiakhq bot merged commit 43b063b into carbon-design-system:master Mar 6, 2021
@tw15egan tw15egan deleted the fix-skeleton-issues branch March 3, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants