Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tabs): update Tabs skeleton styles #7984

Merged
merged 3 commits into from
Mar 5, 2021

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Mar 4, 2021

Closes #7970

Updates Tabs skeleton styles

Changelog

New

  • Tabs Skeleton styles have been updated for both variants

Changed

  • Tabs.Skeleton now renders DOM elements with the current classes
  • Updates Skeleton story to switch between variants/change loading state

Testing / Reviewing

Ensure Tabs skeleton variant renders as expected

@netlify
Copy link

netlify bot commented Mar 4, 2021

Deploy preview for carbon-elements ready!

Built with commit a914da6

https://deploy-preview-7984--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 4, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit a914da6

https://deploy-preview-7984--carbon-components-react.netlify.app

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@kodiakhq kodiakhq bot merged commit 05aad71 into carbon-design-system:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs Skeleton not rendering properly
4 participants