fix(DataTable): fix padding issue with sortable, expandable DataTable #7987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 4b144c2 |
|
Deploy preview for carbon-components-react ready! Built with commit 4b144c2 https://deploy-preview-7987--carbon-components-react.netlify.app |
joshblack
approved these changes
Mar 5, 2021
jnm2377
approved these changes
Mar 5, 2021
laurenmrice
approved these changes
Mar 9, 2021
emyarod
approved these changes
Mar 9, 2021
emyarod
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7983
There is an issue with sortable, expandable DataTables and we have a few solutions.
Current:
This PR:
This PR adds back in 1rem of left padding and updates the left padding of the expandable content area as well
An alternative
This retains the current guidance (that focus is adjacent to text) but causes issues when the table header is sortable (has hover states)
Current
Current (on website)
Proposed alternative, with hover issue
Changelog
Changed
4remleft padding (up from3rem)Removed
padding-leftTesting / Reviewing
Open to feedback on how we want to handle this scenario