New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(themes): update module builders for new design tokens #9128
feat(themes): update module builders for new design tokens #9128
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: a6eb146 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60edce292283b40007b5a3ce 😎 Browse the preview: https://deploy-preview-9128--carbon-react-next.netlify.app/ |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 6b6b101 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60e4bc4e3767e50008b6ee9f 😎 Browse the preview: https://deploy-preview-9128--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 6b6b101 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60e4bc4e0bcb2400096d75ba 😎 Browse the preview: https://deploy-preview-9128--carbon-components-react.netlify.app/ |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: a6eb146 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60edce29b304670007dbbf14 😎 Browse the preview: https://deploy-preview-9128--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: a6eb146 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60edce29961dce0007a5c1cb 😎 Browse the preview: https://deploy-preview-9128--carbon-components-react.netlify.app/ |
…at/update-sass-module-builders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emyarod ugh, looks like some more missing tokens. Thanks for the heads up! Will fix today and re-request 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
…at/update-sass-module-builders
cc @tw15egan let me know if you have any questions / thoughts 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and the docs are on point 🚀
This PR updates our builders for themes to use our new token metadata. It also updates our
@carbon/styles
package to use the new tokens, temporarily adding in contextual tokens.This also updates our
@carbon/styles
package to include button tokensChangelog
New
@carbon/themes
Changed
@carbon/styles
with new themes packageRemoved
Testing / Reviewing
themes/scss/modules/generated
to make sure it generates themes and tokensthemes/docs/sass.md
to make sure the package makes sense