Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(themes): update module builders for new design tokens #9128

Merged

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Jul 6, 2021

This PR updates our builders for themes to use our new token metadata. It also updates our @carbon/styles package to use the new tokens, temporarily adding in contextual tokens.

This also updates our @carbon/styles package to include button tokens

Changelog

New

  • Add docs for Sass Modules variant of @carbon/themes
  • Add button tokens

Changed

  • Update builders for our themes package for mixins and variables
  • Update @carbon/styles with new themes package
  • Add temporary tokens

Removed

Testing / Reviewing

  • Verify build passes as expected
  • Inspect theme generation in themes/scss/modules/generated to make sure it generates themes and tokens
  • Review docs in themes/docs/sass.md to make sure the package makes sense

@netlify
Copy link

netlify bot commented Jul 6, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: a6eb146

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60edce292283b40007b5a3ce

😎 Browse the preview: https://deploy-preview-9128--carbon-react-next.netlify.app/

@netlify
Copy link

netlify bot commented Jul 6, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 6b6b101

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60e4bc4e3767e50008b6ee9f

😎 Browse the preview: https://deploy-preview-9128--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 6, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 6b6b101

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60e4bc4e0bcb2400096d75ba

😎 Browse the preview: https://deploy-preview-9128--carbon-components-react.netlify.app/

@netlify
Copy link

netlify bot commented Jul 6, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: a6eb146

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60edce29b304670007dbbf14

😎 Browse the preview: https://deploy-preview-9128--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 6, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: a6eb146

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60edce29961dce0007a5c1cb

😎 Browse the preview: https://deploy-preview-9128--carbon-components-react.netlify.app/

@joshblack joshblack marked this pull request as ready for review July 7, 2021 22:09
@joshblack joshblack requested a review from a team as a code owner July 7, 2021 22:09
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the netlify build has been failing but when I build locally the default and secondary buttons disappear but the other variants look fine for some reason

image

@joshblack
Copy link
Contributor Author

@emyarod ugh, looks like some more missing tokens. Thanks for the heads up! Will fix today and re-request 👍

@joshblack joshblack requested a review from emyarod July 8, 2021 22:12
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@joshblack
Copy link
Contributor Author

cc @tw15egan let me know if you have any questions / thoughts 👀

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and the docs are on point 🚀

@kodiakhq kodiakhq bot merged commit b4ce23c into carbon-design-system:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants