Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): add display names to forward ref components #9591

Merged
merged 8 commits into from
Sep 22, 2021
Merged

feat(react): add display names to forward ref components #9591

merged 8 commits into from
Sep 22, 2021

Conversation

aledavila
Copy link
Contributor

Closes #9459

Added displayName to components that are using forwardRef

Changelog

New

Added to the following components:

  • Popover
  • ComboBox
  • ListBoxMenuItem
  • PaginationNav
  • Toolbar
  • TextInput (PasswordInput)
  • HeaderMenuItem
  • SideNav
  • SideNavLink
  • SideNavMenuItem
  • SideNavSwitcher
  • Switcher

Testing / Reviewing

Make sure components work as intended. Make sure display names are correct

@aledavila aledavila requested a review from a team as a code owner September 2, 2021 20:37
@netlify
Copy link

netlify bot commented Sep 2, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 488dc0d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/614b6c17a1a9100008b30ab4

😎 Browse the preview: https://deploy-preview-9591--carbon-react-next.netlify.app/

@aledavila aledavila mentioned this pull request Sep 2, 2021
71 tasks
@netlify
Copy link

netlify bot commented Sep 2, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 488dc0d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/614b6c176e5b340008291629

😎 Browse the preview: https://deploy-preview-9591--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 2, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 488dc0d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/614b6c17acbbb400083ffecd

😎 Browse the preview: https://deploy-preview-9591--carbon-components-react.netlify.app

@joshblack
Copy link
Contributor

@aledavila I think updating snapshots is the last thing and then we're good to go!

@aledavila aledavila requested a review from a team as a code owner September 13, 2021 06:29
@joshblack
Copy link
Contributor

@aledavila seems like there are some test failures coming up:

image

@kodiakhq kodiakhq bot merged commit a1e11df into carbon-design-system:main Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some components do not have a 'displayName' set
4 participants