Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct auto-generated guidelines links #5855

Merged

Conversation

janhassel
Copy link
Member

@janhassel janhassel commented Aug 13, 2024

Addresses most cases from #5837

Currently, all auto-generated guideline links for components and patterns are leading to 404 pages as they…:

  • use an uppercase first characters instead of lowercase
  • add an unwanted "s" suffix

Before

https://pages.github.ibm.com/cdai-design/pal/Componentss/side-panel/usage

After

https://pages.github.ibm.com/cdai-design/pal/components/side-panel/usage

What did you change?

  • Transform kind (Components | Patterns) to lowercase
  • Remove unwanted "s" suffix

How did you test and verify your work?

Local storybook

@janhassel janhassel requested a review from a team as a code owner August 13, 2024 11:15
@janhassel janhassel requested review from davidmenendez and ariellalgilmore and removed request for a team August 13, 2024 11:15
Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 5d859a2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66bb406879b9280008e5a515
😎 Deploy Preview https://deploy-preview-5855--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@matthewgallo matthewgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @janhassel! 🎉

Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot. ty

@davidmenendez
Copy link
Contributor

@matthewgallo i wanted to point out that this did fix some things, like AboutModal and Tearsheet, which were initially called out, but it looks like some of these urls are still broken. like for cards and datagrid. these may be special circumstances based on the gatsby url structure. so while i think this is merge ready and does help alleviate some problems it's not fixed entirely. just wanted to point that out 👍

@davidmenendez davidmenendez added this pull request to the merge queue Aug 13, 2024
Merged via the queue into carbon-design-system:main with commit 9713171 Aug 13, 2024
22 checks passed
@janhassel janhassel deleted the storybook-usage-links branch August 14, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants