Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add compatibility for Storybook 'Docs' layout modules 'Library' styles #1114

Merged
merged 2 commits into from
Oct 12, 2021
Merged

docs: add compatibility for Storybook 'Docs' layout modules 'Library' styles #1114

merged 2 commits into from
Oct 12, 2021

Conversation

SimonFinney
Copy link
Contributor

@SimonFinney SimonFinney commented Oct 9, 2021 •
edited
Loading

Affected issue

Contributes to #973

Proposed changes

  • Pass parameters to layout modules 'Library' story to add compatibility for Storybook style setup in ibm-cloud-cognitive
  • Format Markdown to fix style issue observed in ibm-cloud-cognitive
Expected Actual
Expected Actual

@SimonFinney SimonFinney requested a review from a team as a code owner October 9, 2021 14:31
@SimonFinney SimonFinney requested review from lily-peng and removed request for a team October 9, 2021 14:31
@netlify
Copy link

netlify bot commented Oct 9, 2021 •
edited
Loading

✔️ Deploy Preview for ibm-security ready!

🔨 Explore the source changes: 04aa85f

🔍 Inspect the deploy log: https://app.netlify.com/sites/ibm-security/deploys/616589f7280dc600080ba8f4

😎 Browse the preview: https://deploy-preview-1114--ibm-security.netlify.app/

@SimonFinney SimonFinney removed the request for review from lily-peng October 9, 2021 14:48
@SimonFinney SimonFinney changed the title docs(library): add Storybook layout modules library compatibility docs: add Storybook layout modules library compatibility Oct 12, 2021
@SimonFinney SimonFinney changed the title docs: add Storybook layout modules library compatibility docs: add compatibility for Storybook 'Docs' LayoutModules 'Library' styles Oct 12, 2021
@SimonFinney SimonFinney changed the title docs: add compatibility for Storybook 'Docs' LayoutModules 'Library' styles docs: add compatibility for Storybook 'Docs' layout modules 'Library' styles Oct 12, 2021
@kodiakhq kodiakhq bot merged commit 87204dd into dev Oct 12, 2021
@kodiakhq kodiakhq bot deleted the layout-modules-library-compatibility branch October 12, 2021 13:28
@SimonFinney
Copy link
Contributor Author

🎉 This PR is included in version 1.46.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-balchin-ibm paul-balchin-ibm paul-balchin-ibm approved these changes

@dbrugger dbrugger Awaiting requested review from dbrugger

Assignees
No one assigned
Labels
released status: ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimonFinney @paul-balchin-ibm