Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ICA): Add optional information and iconButton prop #1116

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

clairek20
Copy link
Contributor

Reverts #1115

@clairek20 clairek20 requested a review from a team as a code owner October 12, 2021 08:29
@clairek20 clairek20 requested review from j1mie and removed request for a team October 12, 2021 08:29
@SimonFinney SimonFinney changed the title Revert "Revert "feat(ICA): Add optional information and iconButton prop"" feat(ICA): Add optional information and iconButton prop Oct 12, 2021
Copy link
Contributor

@SimonFinney SimonFinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — thanks

@netlify
Copy link

netlify bot commented Oct 12, 2021

✔️ Deploy Preview for ibm-security ready!

🔨 Explore the source changes: eafc440

🔍 Inspect the deploy log: https://app.netlify.com/sites/ibm-security/deploys/61654aab952b6d00070e8d28

😎 Browse the preview: https://deploy-preview-1116--ibm-security.netlify.app/

@kodiakhq kodiakhq bot merged commit 92bac13 into dev Oct 12, 2021
@kodiakhq kodiakhq bot deleted the revert-1115-revert-1110-make_label_and_value_prop_node branch October 12, 2021 08:51
SimonFinney pushed a commit that referenced this pull request Oct 12, 2021
# [1.45.0-prerelease.13](v1.45.0-prerelease.12...v1.45.0-prerelease.13) (2021-10-12)

### Reverts

* Revert "Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115)" (#1116) ([92bac13](92bac13)), closes [#1110](#1110) [#1115](#1115) [#1116](#1116)
@SimonFinney
Copy link
Contributor

🎉 This PR is included in version 1.45.0-prerelease.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

SimonFinney pushed a commit that referenced this pull request Oct 13, 2021
# [1.46.0](v1.45.0...v1.46.0) (2021-10-13)

### Bug Fixes

* **decorator:** fix icon `fill` styles ([#1103](#1103)) ([dea56f9](dea56f9))
* **nav-item-link:** remove fixed height to prevent issues with multi-line text ([#1085](#1085)) ([0e0f542](0e0f542))
* **navitem:** Remove blue lines in safari ([#1106](#1106)) ([5cae584](5cae584))
* **storybook:** Update addon-storysource for renamed Layout Modules ([#1108](#1108)) ([8a3933a](8a3933a))
* **tearsheet-small:** update maximum size styles ([#968](#968)) ([d8bc055](d8bc055))
* **toolbar:** vertical icon alignment for multi-line labels ([#1089](#1089)) ([0183591](0183591))

### Features

* **decorator:** add onContextMenu to decorator ([#1102](#1102)) ([46f29da](46f29da))
* **deps:** add remaining Carbon dependencies ([#1101](#1101)) ([c5bd47b](c5bd47b))
* **focus-trap-react:** upgrade package and fix dependency ([#1111](#1111)) ([ffe9c8a](ffe9c8a))

### Reverts

* Revert "Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115)" (#1116) ([92bac13](92bac13)), closes [#1110](#1110) [#1115](#1115) [#1116](#1116)
* Revert "feature(ICA): Add optional information and iconButton prop (#1110)" (#1115) ([86ad1c7](86ad1c7)), closes [#1110](#1110) [#1115](#1115)
@SimonFinney
Copy link
Contributor

🎉 This PR is included in version 1.46.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants