Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require requests[security] for cb6 to work #63

Merged
merged 1 commit into from
May 5, 2017

Conversation

brianebeyer
Copy link
Contributor

No description provided.

@jgarman
Copy link
Contributor

jgarman commented May 5, 2017

What versions of python does this fail on? I just tested with Python 2.6.6 on CentOS 6 (the oldest we support) and it worked with "plain" requests - albeit with warnings to a Cb Response 6.1.0.170405.0957 server.

Adding [security] does require you to install several C libraries which makes life more difficult- but if we can't connect at all under certain circumstances, then obviously we have to bite the bullet and document the changes for those running ancient versions of python.

@brianebeyer
Copy link
Contributor Author

Mac 10.12.4, standard Python 2.7.10

Without 'requests[security]', it fails to connect every time. We used this link (https://github.com/kennethreitz/requests/issues/3189) to lead us to the solution.

@jgarman
Copy link
Contributor

jgarman commented May 5, 2017

OK thanks - I'll add some text around how to install the devel libraries required to build the ffi and cryptography python modules and test on Windows.

@jgarman jgarman merged commit 1394929 into carbonblack:master May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants