This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
added android x86 support #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,16 +11,16 @@ LOCAL_PATH := $(call my-dir) | |||
| LOCAL_DMZ_DIR := card.io-dmz | |||
|
|
|||
| # --- declare opencv prebuilt static libs --------------------------------- | |||
| ifneq (,$(filter $(TARGET_ARCH_ABI),armeabi-v7a)) | |||
| ifneq (,$(filter $(TARGET_ARCH_ABI),armeabi-v7a x86)) | |||
There was a problem hiding this comment.
I believe there's a missing comma here... should be armeabi-v7a, x86
There was a problem hiding this comment.
I don't think so. The last argument is supposed to be a plain string. filter will look for the presence of the current arch into that string and return armeabi-v7a or x86 if it's the current arch. In these cases the return value will not be empty and the block will be executed, as expected.
There was a problem hiding this comment.
This syntax was already used in Android.mk:79: https://github.com/card-io/card.io-Android-source/blob/master/card.io/src/main/jni/Android.mk#L79
|
Thanks for the PR! I rebased on master, rebuilt the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here is a pull request that simply adds proper support for Android x86 devices.
I've fixed the OpenCV build script to make it generate x86 libs and I've added these to the build too.
I've also modified Android.mk and and CardScanner.java to allow for building and loading the recognizer on x86 devices.
Successfully tested on a recent Asus Zenfone 2 ZE551ML running Lollipop and a 2012' Orange San Diego running Kitkat.