Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mithril] release 2412.0 changed the mithril-client command/subcommand structure #1759

Closed
TrevorBenson opened this issue Apr 16, 2024 · 0 comments · Fixed by #1761
Closed
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation scripts Update to scripts in guild-operators

Comments

@TrevorBenson
Copy link
Collaborator

Describe the bug
The snapshot download used to be called via mithril-client using command subcommand structures. The download was snapshot download, there was also snapshot list and snapshot show. All snapshot logic is now contained inside cardano-db, but has also been restructured so download is a direct subcommand of cardano-db (i.e. cardano-db download) while the show and list subcommands remain as part of snapshot.

The current scripts still use the old method of snapshot download which is being deprecated.

cardano-db
    download
    snapshot
        list
        show

Other commands like mithril-stake-distribution appear unchanged.

Additional context
The scripts should use the updated structure to future proof for when full deprecation removes snapshot as a command and cardano-db download is the only method to download the database (snapshot).

TrevorBenson added a commit to TrevorBenson/guild-operators that referenced this issue Apr 17, 2024
TrevorBenson added a commit to TrevorBenson/guild-operators that referenced this issue Apr 17, 2024
mithril-client binary command/subcommand changes replace snapshot with cardano-db cardano-community#1759
TrevorBenson added a commit that referenced this issue Apr 17, 2024
mithril-client binary command/subcommand changes replace snapshot with cardano-db #1759
@TrevorBenson TrevorBenson self-assigned this Apr 17, 2024
@TrevorBenson TrevorBenson added bug Something isn't working documentation Improvements or additions to documentation scripts Update to scripts in guild-operators labels Apr 17, 2024
TrevorBenson added a commit to TrevorBenson/guild-operators that referenced this issue Apr 27, 2024
* syntactic bug in entrypoint.sh cardano-community#1757

* Remove uneeded UPDATE_CHECK=N exports now that it is a default of the image ENV variables

* export G_ACCOUNT so guild-deploy.sh inherits it during forked builds

* Set defaults for G_ACCOUNT and GUILD_DEPLOY_BRANCH to simplify manual docker build commands

* Fix bug where updating cncli.sh cardano-community#1756

mithril-client binary command/subcommand changes replace snapshot with cardano-db cardano-community#1759

* Add reference to MITHRIL_DOWNLOAD for snapshot sync in regular docs

* export each line of mithril.env for the signer
use tee for logging to not hide issues/errors

* Fix for PARTY_ID used in verify_signer_request and verify_signer_signature

* Move sanchonet to RELEASE=testing

* SANCHONET/PREVIEW - adjustments to support sanchonet and preview versions of mithril for guild-deploy.sh downloading.

* SANCHONET/PREVIEW - adjustments to support sanchonet and preview versions of mithril for entrypoint.sh .

* linting and indentation consistentcy for entrypoint.sh

* Workflows to update mithril and node prerelease versions in preview branch, and mithril unstable version in sanchonet branch.

* Workflows to rebase preview and sanchonet branches on push to alpha, or workflow dispatch.

---------

Co-authored-by: RdLrT <3169068+rdlrt@users.noreply.github.com>
TrevorBenson added a commit to TrevorBenson/guild-operators that referenced this issue Apr 27, 2024
* syntactic bug in entrypoint.sh cardano-community#1757

* Remove uneeded UPDATE_CHECK=N exports now that it is a default of the image ENV variables

* export G_ACCOUNT so guild-deploy.sh inherits it during forked builds

* Set defaults for G_ACCOUNT and GUILD_DEPLOY_BRANCH to simplify manual docker build commands

* Fix bug where updating cncli.sh cardano-community#1756

mithril-client binary command/subcommand changes replace snapshot with cardano-db cardano-community#1759

* Add reference to MITHRIL_DOWNLOAD for snapshot sync in regular docs

* export each line of mithril.env for the signer
use tee for logging to not hide issues/errors

* Fix for PARTY_ID used in verify_signer_request and verify_signer_signature

* Move sanchonet to RELEASE=testing

* SANCHONET/PREVIEW - adjustments to support sanchonet and preview versions of mithril for guild-deploy.sh downloading.

* SANCHONET/PREVIEW - adjustments to support sanchonet and preview versions of mithril for entrypoint.sh .

* linting and indentation consistentcy for entrypoint.sh

* Workflows to update mithril and node prerelease versions in preview branch, and mithril unstable version in sanchonet branch.

* Workflows to rebase preview and sanchonet branches on push to alpha, or workflow dispatch.

* Docker Image workflow determine cnversion to use based on the guild_deploy_branch name.
- When branch preview/sanchonet use prerelease node version.
- For any other branch use the original logic for latest (stable) node version.

---------

Co-authored-by: RdLrT <3169068+rdlrt@users.noreply.github.com>
TrevorBenson added a commit to TrevorBenson/guild-operators that referenced this issue Apr 27, 2024
* syntactic bug in entrypoint.sh cardano-community#1757

* Remove uneeded UPDATE_CHECK=N exports now that it is a default of the image ENV variables

* export G_ACCOUNT so guild-deploy.sh inherits it during forked builds

* Set defaults for G_ACCOUNT and GUILD_DEPLOY_BRANCH to simplify manual docker build commands

* Fix bug where updating cncli.sh cardano-community#1756

mithril-client binary command/subcommand changes replace snapshot with cardano-db cardano-community#1759

* Add reference to MITHRIL_DOWNLOAD for snapshot sync in regular docs

* export each line of mithril.env for the signer
use tee for logging to not hide issues/errors

* Fix for PARTY_ID used in verify_signer_request and verify_signer_signature

* Move sanchonet to RELEASE=testing

* SANCHONET/PREVIEW - adjustments to support sanchonet and preview versions of mithril for guild-deploy.sh downloading.

* SANCHONET/PREVIEW - adjustments to support sanchonet and preview versions of mithril for entrypoint.sh .

* linting and indentation consistentcy for entrypoint.sh

* Workflows to get updated pre/unstable release as well as rebase preview and sanchonet branches. Occurs on push to alpha, workflow dispatch, and scheduled intervals

* Docker Image workflow determine cnversion to use based on the guild_deploy_branch name.
   - When branch preview/sanchonet use prerelease node version.
   - For any other branch use the original logic for latest (stable) node version.

---------

Co-authored-by: RdLrT <3169068+rdlrt@users.noreply.github.com>
TrevorBenson added a commit to TrevorBenson/guild-operators that referenced this issue Apr 28, 2024
* syntactic bug in entrypoint.sh cardano-community#1757

* Remove uneeded UPDATE_CHECK=N exports now that it is a default of the image ENV variables

* export G_ACCOUNT so guild-deploy.sh inherits it during forked builds

* Set defaults for G_ACCOUNT and GUILD_DEPLOY_BRANCH to simplify manual docker build commands

* Fix bug where updating cncli.sh cardano-community#1756

mithril-client binary command/subcommand changes replace snapshot with cardano-db cardano-community#1759

* Add reference to MITHRIL_DOWNLOAD for snapshot sync in regular docs

* export each line of mithril.env for the signer
use tee for logging to not hide issues/errors

* Fix for PARTY_ID used in verify_signer_request and verify_signer_signature

* Move sanchonet to RELEASE=testing

* SANCHONET/PREVIEW - adjustments to support sanchonet and preview versions of mithril for guild-deploy.sh downloading.

* SANCHONET/PREVIEW - adjustments to support sanchonet and preview versions of mithril for entrypoint.sh .

* linting and indentation consistentcy for entrypoint.sh

* Workflows to get updated pre/unstable release as well as rebase preview and sanchonet branches. Occurs on push to alpha, workflow dispatch, and scheduled intervals

* Docker Image workflow determine cnversion to use based on the guild_deploy_branch name.
   - When branch preview/sanchonet use prerelease node version.
   - For any other branch use the original logic for latest (stable) node version.

* fixup! Workflows to get updated pre/unstable release as well as rebase preview and sanchonet branches. Occurs on push to alpha, workflow dispatch, and scheduled intervals

* fixup! Workflows to get updated pre/unstable release as well as rebase preview and sanchonet branches. Occurs on push to alpha, workflow dispatch, and scheduled intervals

* fixup! Workflows to get updated pre/unstable release as well as rebase preview and sanchonet branches. Occurs on push to alpha, workflow dispatch, and scheduled intervals

* fixup! Workflows to get updated pre/unstable release as well as rebase preview and sanchonet branches. Occurs on push to alpha, workflow dispatch, and scheduled intervals

* fixup! Workflows to get updated pre/unstable release as well as rebase preview and sanchonet branches. Occurs on push to alpha, workflow dispatch, and scheduled intervals

* fixup! Workflows to get updated pre/unstable release as well as rebase preview and sanchonet branches. Occurs on push to alpha, workflow dispatch, and scheduled intervals

* fixup! Workflows to get updated pre/unstable release as well as rebase preview and sanchonet branches. Occurs on push to alpha, workflow dispatch, and scheduled intervals

* fixup! Workflows to get updated pre/unstable release as well as rebase preview and sanchonet branches. Occurs on push to alpha, workflow dispatch, and scheduled intervals

* fixup! Docker Image workflow determine cnversion to use based on the guild_deploy_branch name.    - When branch preview/sanchonet use prerelease node version.    - For any other branch use the original logic for latest (stable) node version.
fixup!

* fixup! SANCHONET/PREVIEW - adjustments to support sanchonet and preview versions of mithril for guild-deploy.sh downloading.

* fixup! Docker Image workflow determine cnversion to use based on the guild_deploy_branch name.    - When branch preview/sanchonet use prerelease node version.    - For any other branch use the original logic for latest (stable) node version.

---------

Co-authored-by: RdLrT <3169068+rdlrt@users.noreply.github.com>
TrevorBenson added a commit to TrevorBenson/guild-operators that referenced this issue Apr 28, 2024
* syntactic bug in entrypoint.sh cardano-community#1757

* Remove uneeded UPDATE_CHECK=N exports now that it is a default of the image ENV variables

* export G_ACCOUNT so guild-deploy.sh inherits it during forked builds

* Set defaults for G_ACCOUNT and GUILD_DEPLOY_BRANCH to simplify manual docker build commands

* Fix bug where updating cncli.sh cardano-community#1756

mithril-client binary command/subcommand changes replace snapshot with cardano-db cardano-community#1759

* Add reference to MITHRIL_DOWNLOAD for snapshot sync in regular docs

* export each line of mithril.env for the signer
use tee for logging to not hide issues/errors

* Fix for PARTY_ID used in verify_signer_request and verify_signer_signature

* Move sanchonet to RELEASE=testing

* Update configs and node version support for 8.9.x (cardano-community#1743)

## Description
<!--- Describe your changes -->

- [x] Update topology formats
- [x] Update baseline node version references
- [x] Update node/cli dependency refs and pre-downloaded binaries
- [x] Update document references
- [x] Update dbsync version

* SANCHONET/PREVIEW - adjustments to support sanchonet and preview versions of mithril for guild-deploy.sh downloading.

* linting and indentation consistentcy for entrypoint.sh

* Workflows to get updated pre/unstable release as well as rebase preview and sanchonet branches. Occurs on push to alpha, workflow dispatch, and scheduled intervals

* Docker Image workflow determine cnversion to use based on the guild_deploy_branch name.
   - When branch preview/sanchonet use prerelease node version.
   - For any other branch use the original logic for latest (stable) node version.

---------

Co-authored-by: RdLrT <3169068+rdlrt@users.noreply.github.com>
TrevorBenson added a commit to TrevorBenson/guild-operators that referenced this issue Apr 28, 2024
mithril-client binary command/subcommand changes replace snapshot with cardano-db cardano-community#1759
TrevorBenson added a commit to TrevorBenson/guild-operators that referenced this issue Apr 28, 2024
* syntactic bug in entrypoint.sh cardano-community#1757

* Remove uneeded UPDATE_CHECK=N exports now that it is a default of the image ENV variables

* export G_ACCOUNT so guild-deploy.sh inherits it during forked builds

* Set defaults for G_ACCOUNT and GUILD_DEPLOY_BRANCH to simplify manual docker build commands

* Fix bug where updating cncli.sh cardano-community#1756

mithril-client binary command/subcommand changes replace snapshot with cardano-db cardano-community#1759

* Add reference to MITHRIL_DOWNLOAD for snapshot sync in regular docs

* export each line of mithril.env for the signer
use tee for logging to not hide issues/errors

* Fix for PARTY_ID used in verify_signer_request and verify_signer_signature

* Move sanchonet to RELEASE=testing

* SANCHONET/PREVIEW - adjustments to support sanchonet and preview versions of mithril for guild-deploy.sh downloading.

* linting and indentation consistentcy for entrypoint.sh

* Workflows to get updated pre/unstable release as well as rebase preview and sanchonet branches. Occurs on push to alpha, workflow dispatch, and scheduled intervals

* Docker Image workflow determine cnversion to use based on the guild_deploy_branch name.
   - When branch preview/sanchonet use prerelease node version.
   - For any other branch use the original logic for latest (stable) node version.
TrevorBenson added a commit that referenced this issue May 3, 2024
mithril-client binary command/subcommand changes replace snapshot with cardano-db #1759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation scripts Update to scripts in guild-operators
Projects
None yet
1 participant