Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guild LiveView 1.2 - Peer list navigation #490

Merged
merged 2 commits into from
Sep 19, 2020
Merged

Guild LiveView 1.2 - Peer list navigation #490

merged 2 commits into from
Sep 19, 2020

Conversation

Scitz0
Copy link
Contributor

@Scitz0 Scitz0 commented Sep 19, 2020

  • Added support to cycle through all peers using left/right arrow keys. 'o'(outgoing)/'i'(incoming) keys used to select active list to navigate.
  • endline function replaced with printf fillers. Fixes flickering in certain conditions as line was first cleared and then redrawn.
  • Improved handling of 0 peer lists
  • Add uptime and title to Peer Analysis view
  • Various minor improvements

@Scitz0
Guild LiveView 1.2 - Peer list navigation
8c9bdae 
- Added support to cycle through all peers using left/right arrow keys. 'o'(outgoing)/'i'(incoming) keys used to select active list to navigate.
- endline function replaced with printf fillers. Fixes flickering in certain conditions as line was first cleared and then redrawn.
- Improved handling of 0 peer lists
- Add uptime and title to Peer Analysis view
- Various minor improvements
@Scitz0 Scitz0 requested a review from rdlrt September 19, 2020 14:13
rdlrt
rdlrt approved these changes Sep 19, 2020
View reviewed changes
Copy link
Contributor

@rdlrt rdlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, arrow key may not be as obvious to some, perhaps we can add a comment somewhere - but rest is good

@Scitz0
Copy link
Contributor Author

Scitz0 commented Sep 19, 2020

LGTM, arrow key may not be as obvious to some, perhaps we can add a comment somewhere - but rest is good

Good idea, added

@Scitz0 Scitz0 merged commit ee9253e into master Sep 19, 2020
@Scitz0 Scitz0 deleted the gLiveView-navigation branch September 19, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdlrt rdlrt rdlrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Scitz0 @rdlrt