Replace `hardfork_at` with `eras` object, and add node_era #2468

Anviking · 2021-01-26T15:00:33Z

Issue Number

Overview

Instead of storing ProtocolParameters in DB, just keep them in a TVar
Remove problem where the wallet might use genesis-derived protocol parameters and era on wallet start up, until the node first changed tip.
Replace hardfork_at with info of all eras
Add new node_era field in GET /network/information
~~See if we can order the eras correctly in the era object (for when the JSON is viewed by humans)~~ Seems impossible to do.

Comments

Could add absolute slot field also
Arguably a bit sad that the eras get sorted seemingly alphabetically in the json

$ cardano-wallet network parameters
{
    "slot_length": {
        "quantity": 1,
        "unit": "second"
    },
    "decentralization_level": {
        "quantity": 74,
        "unit": "percent"
    },
    "genesis_block_hash": "5f20df933584822601f9e3f8c024eb5eb252fe8cefb24d1317dc3d432e940ebb",
    "blockchain_start_time": "2017-09-23T21:44:51Z",
    "desired_pool_number": 500,
    "epoch_length": {
        "quantity": 432000,
        "unit": "slot"
    },
    "eras": {
        "shelley": {
            "epoch_start_time": "2020-07-29T21:44:51Z",
            "epoch_number": 208
        },
        "mary": null,
        "byron": {
            "epoch_start_time": "2017-09-23T21:44:51Z",
            "epoch_number": 0
        },
        "allegra": {
            "epoch_start_time": "2020-12-16T21:44:51Z",
            "epoch_number": 236
        }
    },
    "active_slot_coefficient": {
        "quantity": 5,
        "unit": "percent"
    },
    "security_parameter": {
        "quantity": 2160,
        "unit": "block"
    },
    "minimum_utxo_value": {
        "quantity": 1000000,
        "unit": "lovelace"
    }
}

Anviking · 2021-01-26T15:30:48Z

lib/core/src/Cardano/Wallet/Api/Types.hs

@@ -2190,6 +2190,11 @@ taggedSumTypeOptions base opts = base
    { sumEncoding = TaggedObject (_tagFieldName opts) (_contentsFieldName opts)
    }

+explicitNothingRecordTypeOptions :: Aeson.Options
+explicitNothingRecordTypeOptions = defaultRecordTypeOptions
+    { omitNothingFields = False


Not sure why this is enabled by default…

"Is the mary key not present because the wallet is not supporting mary, or because the mary fork has not yet occurred?"

Explicit null for the latter case seems much clearer.

I agree that the absence of a field doesn't have the same meaning as a null value. I think that in the context of our API indeed, we most likely always want fields corresponding to Maybe values to be present 🤔

Anviking · 2021-01-27T14:03:01Z

lib/core-integration/src/Test/Integration/Scenario/API/Shelley/Network.hs

@@ -51,7 +51,8 @@ spec = describe "SHELLEY_NETWORK" $ do
            [ expectField #decentralizationLevel (`shouldBe` d)
            , expectField #desiredPoolNumber (`shouldBe` nOpt)
            , expectField #minimumUtxoValue (`shouldBe` Quantity minUTxOValue)
-            , expectField #hardforkAt (`shouldNotBe` Nothing)
+            , expectField (#eras . #shelley) (`shouldNotBe` Nothing)
+            , expectField (#eras . #byron) (`shouldNotBe` Nothing)


Integration tests can in practice be run on any shelley-based era. So simply testing that at least byron and shelley are not null, should be pretty good.

but then you will not receive information about mary and allegra, right? 🤔

Ok, fine, we can probably make the expectation dependent on the LOCAL_CLUSTER_ERA value, by storing it in the test Context

Hm, seems unexpectedly tedious though… (Can't use a shelley type in cardano-wallet-core-integration) Will look more at it later.

Anviking · 2021-01-27T14:07:58Z

specifications/api/swagger.yaml

+        If and when each era started or will start.
+
+        The object is keyed by era names. The values either describe the epoch boundary
+        when the era starts (can be in the future or in the past), or are null if not yet
+        confirmed on-chain.


Because of

(can be in the future or in the past)

wouldn't it make sense to provide a era field either here, or in /network/information?

A non-null mary does not necessarily mean that we're in Mary. We could also be just before Mary.

I thought it would go like this : we know something like mary will happen (null), then we know when it happens (by specifying era it starts), and we also now current slot/era. So everything is fine;-)

paweljakubas · 2021-01-27T14:12:03Z

lib/core/src/Cardano/Wallet/Api/Types.hs

@@ -749,15 +751,30 @@ data ApiNetworkParameters = ApiNetworkParameters
    , decentralizationLevel :: !(Quantity "percent" Percentage)
    , desiredPoolNumber :: !Word16
    , minimumUtxoValue :: !(Quantity "lovelace" Natural)
-    , hardforkAt :: !(Maybe ApiEpochInfo)
+    , eras :: !ApiEraInfo


why not to have

eras: [ApiEraInfo] ... data Eras = Byron | Shelley | Allegra | Mary deriving (Eq, Ord, Show) data ApiEraInfo = ApiEraInfo { hardForkToEra :: !Era hardFromEra :: !(Maybe Era) timeOfTransition:: !(Maybe ApiEpochInfo) }

?

I think it is more robust in a sense that when new hard forks arrive they will just add new element to list. But maybe there is some rationale behind this way of storing era transitions?

@KtorZ advocated for an object keyed by era-name since Daedalus wants to do stuff like isAllegra and isShelley, and already have to be highly aware of e.g. the ordering of them.

Although with #2468 (comment) in mind, I wonder if this changes 🤔

Seems we should indeed add some kind of currentEra field somewhere.

Maybe we should make this a list then, yes 🤔

Off the top of my head I would probably just do

data ApiEraInfo = ApiEraInfo { eraName :: !Era start :: !(Maybe ApiEpochInfo) }

since hardFromEra doesn't provide any extra information.

In-doubt I would stick to the current object format. I think it still has its qualities too. If you feel strongly about it, feel free to disagree.

But I imagine, if a need arises where a list would be great for Daedalus, we can change it then. Currently the need for this is unclear.

you got me wrong Johannes. I like your proposal, just was thinking loudly and sharing some ideas ;-) no pun intended.great job!

paweljakubas · 2021-01-27T14:15:21Z

lib/core/src/Cardano/Wallet/Primitive/Types.hs

+-- It might be cumbersome to work with this type. /But/ we don't need to. A
+-- product of @Maybe@ is both what we can query from the node, and
+-- what we need to provide in the wallet API.
+data EraInfo info = EraInfo


If you opt for my suggestion of ApiEraInfo then this part should also comply

paweljakubas · 2021-01-27T14:17:36Z

lib/shelley/src/Cardano/Wallet/Shelley/Network.hs

-                _ ->
-                    LSQry $ QueryAnytimeMary GetEraStart
+            eraBounds <- W.EraInfo
+                <$> LSQry (QueryAnytimeByron GetEraStart)


paweljakubas · 2021-01-27T14:18:09Z

specifications/api/swagger.yaml

+      <<: *epochInfo
+      nullable: True
+
+    ApiEraInfo: &ApiEraInfo


the same here in case ApiEraInfo is refactored

KtorZ

Sounds good, provided that we make sure of the behavior on start-up with regards to protocol parameters. I'd expect the server to block on a particular request until protocol parameters become available.

KtorZ · 2021-01-26T16:05:50Z

lib/core-integration/src/Test/Integration/Scenario/API/Shelley/Network.hs

@@ -51,7 +51,8 @@ spec = describe "SHELLEY_NETWORK" $ do
            [ expectField #decentralizationLevel (`shouldBe` d)
            , expectField #desiredPoolNumber (`shouldBe` nOpt)
            , expectField #minimumUtxoValue (`shouldBe` Quantity minUTxOValue)
-            , expectField #hardforkAt (`shouldNotBe` Nothing)
+            , expectField (#eras . #shelley) (`shouldNotBe` Nothing)
+            , expectField (#eras . #byron) (`shouldNotBe` Nothing)


KtorZ · 2021-01-27T15:14:37Z

lib/core/src/Cardano/Wallet/Api/Types.hs

@@ -2190,6 +2190,11 @@ taggedSumTypeOptions base opts = base
    { sumEncoding = TaggedObject (_tagFieldName opts) (_contentsFieldName opts)
    }

+explicitNothingRecordTypeOptions :: Aeson.Options
+explicitNothingRecordTypeOptions = defaultRecordTypeOptions
+    { omitNothingFields = False


I agree that the absence of a field doesn't have the same meaning as a null value. I think that in the context of our API indeed, we most likely always want fields corresponding to Maybe values to be present 🤔

KtorZ · 2021-01-27T15:15:13Z

lib/core/test/data/Cardano/Wallet/Api/ApiEraInfo.json

+                "epoch_start_time": "1891-03-26T08:00:00Z",
+                "epoch_number": 53
+            },
+            "byron": null,


That would be problematic in practice :)

Anviking · 2021-01-28T10:23:52Z

bors r+

2468: Replace `hardfork_at` with `eras` object r=Anviking a=Anviking # Issue Number ADP-676 # Overview  - [x] Replace `hardfork_at` with info of all eras - [x] Instead of storing ProtocolParameters in DB, just keep them in a `TVar` - [ ] <s>See if we can order the eras correctly in the `era` object (for when the JSON is viewed by humans)</s> Seems impossible to do. - [x] TODO: Extend swagger - [ ] Tiny doc tweaks # Comments - Could add absolute `slot` field also - Arguably a bit sad that the eras get sorted seemingly alphabetically in the json ```json $ cardano-wallet network parameters { "slot_length": { "quantity": 1, "unit": "second" }, "decentralization_level": { "quantity": 74, "unit": "percent" }, "genesis_block_hash": "5f20df933584822601f9e3f8c024eb5eb252fe8cefb24d1317dc3d432e940ebb", "blockchain_start_time": "2017-09-23T21:44:51Z", "desired_pool_number": 500, "epoch_length": { "quantity": 432000, "unit": "slot" }, "eras": { "shelley": { "epoch_start_time": "2020-07-29T21:44:51Z", "epoch_number": 208 }, "mary": null, "byron": { "epoch_start_time": "2017-09-23T21:44:51Z", "epoch_number": 0 }, "allegra": { "epoch_start_time": "2020-12-16T21:44:51Z", "epoch_number": 236 } }, "active_slot_coefficient": { "quantity": 5, "unit": "percent" }, "security_parameter": { "quantity": 2160, "unit": "block" }, "minimum_utxo_value": { "quantity": 1000000, "unit": "lovelace" } } ```   Co-authored-by: Johannes Lund <johannes.lund@iohk.io>

iohk-bors · 2021-01-28T10:34:50Z

Build failed:

buildkite/cardano-wallet

#expected

We never want to use the old genesis parameters just because the wallet just started. The onTipUpdate will be run immediately on startup, and will fetch both interpreter, and protocol parameters. To be safe, and for readability, let's replace the TVar+initial val with an empty TMVar though.

Anviking · 2021-01-28T10:51:13Z

bors r+

2468: Replace `hardfork_at` with `eras` object, and add node_era r=Anviking a=Anviking # Issue Number ADP-676 # Overview  - [x] Replace `hardfork_at` with info of all eras - [x] Instead of storing ProtocolParameters in DB, just keep them in a `TVar` - [ ] <s>See if we can order the eras correctly in the `era` object (for when the JSON is viewed by humans)</s> Seems impossible to do. - [x] TODO: Extend swagger - [ ] Tiny doc tweaks # Comments - Could add absolute `slot` field also - Arguably a bit sad that the eras get sorted seemingly alphabetically in the json ```json $ cardano-wallet network parameters { "slot_length": { "quantity": 1, "unit": "second" }, "decentralization_level": { "quantity": 74, "unit": "percent" }, "genesis_block_hash": "5f20df933584822601f9e3f8c024eb5eb252fe8cefb24d1317dc3d432e940ebb", "blockchain_start_time": "2017-09-23T21:44:51Z", "desired_pool_number": 500, "epoch_length": { "quantity": 432000, "unit": "slot" }, "eras": { "shelley": { "epoch_start_time": "2020-07-29T21:44:51Z", "epoch_number": 208 }, "mary": null, "byron": { "epoch_start_time": "2017-09-23T21:44:51Z", "epoch_number": 0 }, "allegra": { "epoch_start_time": "2020-12-16T21:44:51Z", "epoch_number": 236 } }, "active_slot_coefficient": { "quantity": 5, "unit": "percent" }, "security_parameter": { "quantity": 2160, "unit": "block" }, "minimum_utxo_value": { "quantity": 1000000, "unit": "lovelace" } } ```   Co-authored-by: Johannes Lund <johannes.lund@iohk.io>

iohk-bors · 2021-01-28T12:09:48Z

Build failed:

ci/hydra-build:required

  rollback
      Can rollback to any arbitrary known checkpoint
        +++ OK, passed 100 tests.
      Correctly re-construct tx history on rollbacks
        +++ OK, passed 800 tests:
        58.4% rolling back something

        41.6% Outgoing tx after point: 0
building of '/nix/store/9yv02wjfqrsrlznkh1affmp2xwh1jr4s-cardano-wallet-core-test-unit-2021.1.12-check' timed out after 900 seconds of silence

Probably related to
#2393
but a timeout

Anviking · 2021-01-28T12:35:07Z

bors r+

2468: Replace `hardfork_at` with `eras` object, and add node_era r=Anviking a=Anviking # Issue Number ADP-676 # Overview  - [x] Replace `hardfork_at` with info of all eras - [x] Instead of storing ProtocolParameters in DB, just keep them in a `TVar` - [ ] <s>See if we can order the eras correctly in the `era` object (for when the JSON is viewed by humans)</s> Seems impossible to do. - [x] TODO: Extend swagger - [ ] Tiny doc tweaks # Comments - Could add absolute `slot` field also - Arguably a bit sad that the eras get sorted seemingly alphabetically in the json ```json $ cardano-wallet network parameters { "slot_length": { "quantity": 1, "unit": "second" }, "decentralization_level": { "quantity": 74, "unit": "percent" }, "genesis_block_hash": "5f20df933584822601f9e3f8c024eb5eb252fe8cefb24d1317dc3d432e940ebb", "blockchain_start_time": "2017-09-23T21:44:51Z", "desired_pool_number": 500, "epoch_length": { "quantity": 432000, "unit": "slot" }, "eras": { "shelley": { "epoch_start_time": "2020-07-29T21:44:51Z", "epoch_number": 208 }, "mary": null, "byron": { "epoch_start_time": "2017-09-23T21:44:51Z", "epoch_number": 0 }, "allegra": { "epoch_start_time": "2020-12-16T21:44:51Z", "epoch_number": 236 } }, "active_slot_coefficient": { "quantity": 5, "unit": "percent" }, "security_parameter": { "quantity": 2160, "unit": "block" }, "minimum_utxo_value": { "quantity": 1000000, "unit": "lovelace" } } ```   Co-authored-by: Johannes Lund <johannes.lund@iohk.io>

iohk-bors · 2021-01-28T13:13:24Z

Build failed:

buildkite/cardano-wallet

Failures:
--
  |  
  | src/Test/Integration/Framework/DSL.hs:780:11:
  | 1) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_JOIN_01rewards - Can join a pool, earn rewards and collect them
  | Quantity {getQuantity = 0} does not satisfy (> Quantity {getQuantity = 0})
  | While verifying (Status {statusCode = 200, statusMessage = "OK"},Right (ApiWallet {id = ApiT {getApiT = WalletId {getWalletId = c83c7e41054d4f96238c00e1a8abf75c7a93f485}}, addressPoolGap = ApiT {getApiT = AddressPoolGap {getAddressPoolGap = 20}}, balance = ApiWalletBalance {available = Quantity {getQuantity = 999998856100}, total = Quantity {getQuantity = 999998856100}, reward = Quantity {getQuantity = 0}}, assets = ApiWalletAssetsBalance {available = ApiT {getApiT = TokenMap (fromList [])}, total = ApiT {getApiT = TokenMap (fromList [])}}, delegation = ApiWalletDelegation {active = ApiWalletDelegationNext {status = Delegating, target = Just (ApiT {getApiT = PoolId {getPoolId = "\ESC=\193\156j\184\158\175\252\133\SOH\243u\187\ETX\193\ESC\248\237]\CAN76\177\216\EOT\DC3\214"}}), changesAt = Nothing}, next = []}, name = ApiT {getApiT = WalletName {getWalletName = "Faucet Wallet"}}, passphrase = Just (ApiWalletPassphraseInfo {lastUpdatedAt = 2021-01-28 13:02:28.321281775 UTC}), state = ApiT {getApiT = Ready}, tip = ApiBlockReference {absoluteSlotNumber = ApiT {getApiT = SlotNo 3749}, slotId = ApiSlotId {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 74}}, slotNumber = ApiT {getApiT = SlotInEpoch {unSlotInEpoch = 49}}}, time = 2021-01-28 13:04:17.8 UTC, block = ApiBlockInfo {height = Quantity {getQuantity = 1300}}}}))
  | Waited longer than 90s to resolve action: "Wallet gets rewards".
  |  
  | To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_JOIN_01rewards - Can join a pool, earn rewards and collect them/"
  |  
  | src/Test/Integration/Framework/DSL.hs:780:11:
  | 2) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_JOIN_04 - Rewards accumulate
  | Quantity {getQuantity = 0} does not satisfy (> Quantity {getQuantity = 0})
  | While verifying (Status {statusCode = 200, statusMessage = "OK"},Right (ApiWallet {id = ApiT {getApiT = WalletId {getWalletId = 27d366bd6cfe862494c2678f82d2613fd6fa8c42}}, addressPoolGap = ApiT {getApiT = AddressPoolGap {getAddressPoolGap = 20}}, balance = ApiWalletBalance {available = Quantity {getQuantity = 999998856100}, total = Quantity {getQuantity = 999998856100}, reward = Quantity {getQuantity = 0}}, assets = ApiWalletAssetsBalance {available = ApiT {getApiT = TokenMap (fromList [])}, total = ApiT {getApiT = TokenMap (fromList [])}}, delegation = ApiWalletDelegation {active = ApiWalletDelegationNext {status = Delegating, target = Just (ApiT {getApiT = PoolId {getPoolId = "\ESC=\193\156j\184\158\175\252\133\SOH\243u\187\ETX\193\ESC\248\237]\CAN76\177\216\EOT\DC3\214"}}), changesAt = Nothing}, next = []}, name = ApiT {getApiT = WalletName {getWalletName = "Faucet Wallet"}}, passphrase = Just (ApiWalletPassphraseInfo {lastUpdatedAt = 2021-01-28 13:02:43.016598676 UTC}), state = ApiT {getApiT = Ready}, tip = ApiBlockReference {absoluteSlotNumber = ApiT {getApiT = SlotNo 3797}, slotId = ApiSlotId {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 75}}, slotNumber = ApiT {getApiT = SlotInEpoch {unSlotInEpoch = 47}}}, time = 2021-01-28 13:04:27.4 UTC, block = ApiBlockInfo {height = Quantity {getQuantity = 1320}}}}))
  | Waited longer than 90s to resolve action: "Wallet gets rewards".
  |  
  | To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_JOIN_04 - Rewards accumulate/"
  |  
  | src/Test/Integration/Framework/DSL.hs:780:11:
  | 3) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_LIST_01 - List stake pools, has non-zero saturation & stake
  | Quantity {getQuantity = Percentage {getPercentage = 0 % 1}} does not satisfy (> Quantity {getQuantity = Percentage {getPercentage = 0 % 1}})
  | While verifying (Status {statusCode = 200, statusMessage = "OK"},Right [ApiStakePool {id = ApiT {getApiT = PoolId {getPoolId = "\ESC=\193\156j\184\158\175\252\133\SOH\243u\187\ETX\193\ESC\248\237]\CAN76\177\216\EOT\DC3\214"}}, metrics = ApiStakePoolMetrics {nonMyopicMemberRewards = Quantity {getQuantity = 906097506287}, relativeStake = Quantity {getQuantity = Percentage {getPercentage = 0 % 1}}, saturation = 1.464843767327409e-5, producedBlocks = Quantity {getQuantity = 4}}, metadata = Nothing, cost = Quantity {getQuantity = 0}, margin = Quantity {getQuantity = Percentage {getPercentage = 1 % 10}}, pledge = Quantity {getQuantity = 2000000000000}, retirement = Nothing, flags = []},ApiStakePool {id = ApiT {getApiT = PoolId {getPoolId = "\187\DC1L\179}u\250\ENQ&\ETX(\194\&5\163\218\226\149\163=\v\166t\165\235\RS>V\142"}}, metrics = ApiStakePoolMetrics {nonMyopicMemberRewards = Quantity {getQuantity = 699331380211}, relativeStake = Quantity {getQuantity = Percentage {getPercentage = 417 % 1000}}, saturation = 1.2510032213152051, producedBlocks = Quantity {getQuantity = 739}}, metadata = Nothing, cost = Quantity {getQuantity = 0}, margin = Quantity {getQuantity = Percentage {getPercentage = 1 % 10}}, pledge = Quantity {getQuantity = 1000000000000}, retirement = Just (ApiEpochInfo {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 1000000}}, epochStartTime = 2021-05-24 06:38:28 UTC}), flags = []},ApiStakePool {id = ApiT {getApiT = PoolId {getPoolId = "\180Wh\193\162\218K\209>\188\170\RS\165\DC4\b\237\163\GS\204!v\\\203\212\a\205\169\242"}}, metrics = ApiStakePoolMetrics {nonMyopicMemberRewards = Quantity {getQuantity = 597988295434}, relativeStake = Quantity {getQuantity = Percentage {getPercentage = 1013 % 2000}}, saturation = 1.519466463252439, producedBlocks = Quantity {getQuantity = 900}}, metadata = Nothing, cost = Quantity {getQuantity = 0}, margin = Quantity {getQuantity = Percentage {getPercentage = 1 % 10}}, pledge = Quantity {getQuantity = 1000000000000}, retirement = Just (ApiEpochInfo {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 100000}}, epochStartTime = 2021-02-09 02:38:28 UTC}), flags = []}])
  | Waited longer than 90s to resolve action: "list pools returns non-empty list".
  |  
  | To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_LIST_01 - List stake pools/has non-zero saturation & stake/"
  |

Possibly:
#2467

Anviking · 2021-01-28T13:26:09Z

bors r+

iohk-bors · 2021-01-28T14:03:34Z

Build succeeded:

Anviking added the IMPROVEMENT Mark a PR as an improvement, for auto-generated CHANGELOG label Jan 26, 2021

Anviking self-assigned this Jan 26, 2021

Anviking marked this pull request as draft January 26, 2021 15:08

Anviking changed the title ~~Replace hardfork_at with info of all eras~~ Replace hardfork_at with eras object Jan 26, 2021

Anviking changed the title ~~Replace hardfork_at with eras object~~ Replace hardfork_at with eras object Jan 26, 2021

Anviking commented Jan 26, 2021

View reviewed changes

nikolaglumac mentioned this pull request Jan 27, 2021

[DDW-539, DDW-541] Fund3 voting registration input-output-hk/daedalus#2315

Merged

56 tasks

Anviking commented Jan 27, 2021

View reviewed changes

paweljakubas reviewed Jan 27, 2021

View reviewed changes

KtorZ approved these changes Jan 27, 2021

View reviewed changes

Anviking force-pushed the anviking/ADP-623/era-info branch 2 times, most recently from ae508e2 to c7c5b7a Compare January 27, 2021 17:50

paweljakubas approved these changes Jan 28, 2021

View reviewed changes

Anviking force-pushed the anviking/ADP-623/era-info branch from 47c5ddc to 75c4f4e Compare January 28, 2021 09:46

Anviking marked this pull request as ready for review January 28, 2021 10:00

Anviking force-pushed the anviking/ADP-623/era-info branch from 75c4f4e to 5f18e58 Compare January 28, 2021 10:23

Anviking changed the title ~~Replace hardfork_at with eras object~~ Replace hardfork_at with eras object, and add node_era Jan 28, 2021

Anviking added 6 commits January 28, 2021 11:45

Remove ProtocolParameters from DB

b1a3df8

Replace hardfork_at with eras

75fd21b

Ensure the node era is immediately known

c720bb3

Add node_era field to GET /network/information

544488b

Workaround problem from marking ApiEraInfo fields required

f448ab7

Anviking force-pushed the anviking/ADP-623/era-info branch from 5f18e58 to f448ab7 Compare January 28, 2021 10:45

iohk-bors bot merged commit cab62e9 into master Jan 28, 2021

iohk-bors bot deleted the anviking/ADP-623/era-info branch January 28, 2021 14:03

KtorZ mentioned this pull request Jan 28, 2021

RoundRobin multi-asset coin-selection integration in cardano-wallet #2462

Merged

8 tasks

nikolaglumac mentioned this pull request Jan 29, 2021

[DDW-557] Update cardano-wallet input-output-hk/daedalus#2325

Merged

37 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace `hardfork_at` with `eras` object, and add node_era #2468

Replace `hardfork_at` with `eras` object, and add node_era #2468

Anviking commented Jan 26, 2021 •

edited

Anviking Jan 26, 2021 •

edited

KtorZ Jan 27, 2021

Anviking Jan 27, 2021

paweljakubas Jan 27, 2021

Anviking Jan 27, 2021

Anviking Jan 27, 2021 •

edited

Anviking Jan 27, 2021

paweljakubas Jan 27, 2021

paweljakubas Jan 27, 2021

paweljakubas Jan 27, 2021

Anviking Jan 27, 2021

Anviking Jan 27, 2021

Anviking Jan 28, 2021 •

edited

paweljakubas Jan 28, 2021

paweljakubas Jan 27, 2021

paweljakubas Jan 27, 2021

paweljakubas Jan 27, 2021

KtorZ left a comment

KtorZ Jan 26, 2021

KtorZ Jan 27, 2021

KtorZ Jan 27, 2021

Anviking commented Jan 28, 2021

iohk-bors bot commented Jan 28, 2021 •

edited by Anviking

Anviking commented Jan 28, 2021

iohk-bors bot commented Jan 28, 2021 •

edited by Anviking

Anviking commented Jan 28, 2021

iohk-bors bot commented Jan 28, 2021 •

edited by Anviking

Anviking commented Jan 28, 2021

iohk-bors bot commented Jan 28, 2021

Replace hardfork_at with eras object, and add node_era #2468

Replace hardfork_at with eras object, and add node_era #2468

Conversation

Anviking commented Jan 26, 2021 • edited

Issue Number

Overview

Comments

Anviking Jan 26, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Anviking Jan 27, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Anviking Jan 28, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KtorZ left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Anviking commented Jan 28, 2021

iohk-bors bot commented Jan 28, 2021 • edited by Anviking

Anviking commented Jan 28, 2021

iohk-bors bot commented Jan 28, 2021 • edited by Anviking

Anviking commented Jan 28, 2021

iohk-bors bot commented Jan 28, 2021 • edited by Anviking

Anviking commented Jan 28, 2021

iohk-bors bot commented Jan 28, 2021

Replace `hardfork_at` with `eras` object, and add node_era #2468

Replace `hardfork_at` with `eras` object, and add node_era #2468

Anviking commented Jan 26, 2021 •

edited

Anviking Jan 26, 2021 •

edited

Anviking Jan 27, 2021 •

edited

Anviking Jan 28, 2021 •

edited

iohk-bors bot commented Jan 28, 2021 •

edited by Anviking

iohk-bors bot commented Jan 28, 2021 •

edited by Anviking

iohk-bors bot commented Jan 28, 2021 •

edited by Anviking