[DDW-539, DDW-541] Fund3 voting registration

[nikolaglumac]

This PR implements Catalyst "Voting registration" feature (#2204) into develop branch.
It also improves the syncing states of ITN redemption and Staking screens.

Documentation

• Original test plan: https://input-output.atlassian.net/wiki/spaces/QA/pages/1824293038/Voting+Test+Plan
• New feature flow: https://docs.google.com/document/d/1SluIjNM5qF7lB7gp1_mvBRCZcJQG9BG-gwWMy38qlq0/edit#

Designs

https://zpl.io/aMe0XwN

Todos

• Inspect QR code on the "Info" screen on dark themes (@nikolaglumac)
• Implement "Save as PDF" feature (@daniloprates)
• QR code step text alignment and warning text color (@nikolaglumac)
• PIN entry component behaviour (@nikolaglumac)
• Use the same no-wallets pattern as on the "Delegation" wizard
• Implement animation for the progress bar on "Confirm" step
• Implement checkboxes logic on the "QR code" step
• Implement support for all Daedalus themes
• Inject Japanese translations

Todos (derived from the Gap Analysis Report)

Known issues

• Counter stops when screen is not active VIT-739 No longer relevant due to change in UI/UX logic (checking transaction confirmations vs 60 mins time period)
• Can't calculate voting registration transaction fees or submit the transaction in case you start the voting registration close to Daedalus launch (to be fixed in Replace hardfork_at with eras object, and add node_era cardano-foundation/cardano-wallet#2468) - Confirmed to be resolved by [DDW-557] Update cardano-wallet #2325

Code quality improvements

• Implementing fixes for the issues listed in the Code Quality Review
• Improve container/store logic to avoid strange "jumping" between the steps in the dialog (e.g. when you enter wrong wallet passphrase)
• Rename all components and containers from "voting-add" to "voting-registration"

UI/UX improvements

• Implementing fixes for the issues listed in the UI/UX Implementation Review
• Add loading state for the voting UI during Daedalus syncing process
• Add AppStore link for downloading Catalyst Voting App
• Disable voting UI until Daedalus is fully synced
• Disable voting registration for hardware wallets (incl. a display of a dedicated error message)
• Disable voting registration for Byron wallets (incl. a display of a dedicated error message)
• Implement voting registration user flow changes (show on the chart below)
• Implement text copy improvements listed in Text Copy Review (e.g. the link on the Voting Wizard Step#2 leads to an empty Google Document)

Voting registration flow

Screenshots

Staking screen during Daedalus syncing

ITN rewards redemption screen during Daedalus syncing

Voting screen during Daedalus syncing

Voting screen when there are no Shelley-compatible wallets

Voting info screen

Voting registration wizard

QR code PDF

fund3-voting-registration-Shelley Wallet-2021-02-05T193357.0674.pdf
fund3-有権者登録-Shelley Wallet-2021-02-05T194749.0956.pdf

---

Testing Checklist

• Slack QA thread
• Run regression tests for existing Daedalus features
• Run tests of the voting feature

---

Testing Summary

• 1st regression: Testing document link
• 2nd regression: Testing document link

---

Review Checklist

Basics

• PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
• PR is updated to the most recent version of the target branch (and there are no conflicts)
• PR has a good description that summarizes all changes
• PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
  • In English
  • In Japanese
• CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
• Automated tests: All acceptance and unit tests are passing (yarn test)
• Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
• Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
• There are no flow errors or warnings (yarn flow:test)
• There are no lint errors or warnings (yarn lint)
• There are no prettier errors or warnings (yarn prettier:check)
• There are no missing translations (running yarn manage:translations produces no changes)
• Text changes are proofread and approved (Jane Wild / Amy Reeve)
• Japanese text changes are proofread and approved (Junko Oda)
• UI changes look good in all themes (Alexander Rukin)
• Storybook works and no stories are broken (yarn storybook)
• In case of dependency changes yarn.lock file is updated

Code Quality

• Important parts of the code are properly commented and documented
• Code is properly typed with flow
• React components are split-up enough to avoid unnecessary re-renderings
• Any code that only works in main process is neatly separated from components

Testing

• New feature/change is covered by acceptance tests
• New feature/change is manually tested and approved by QA team
• All existing acceptance tests are still up-to-date
• New feature/change is covered by Daedalus Testing scenario
• All existing Daedalus Testing scenarios are still up-to-date

After Review

• Merge the PR
• Delete the source branch
• Move the ticket to done column on the YouTrack board
• Update Slack QA thread by marking it with a green checkmark

[alexander-rukin]

"A wizard is never late, nor is he early, he arrives precisely when he means to."
🧙