Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yaci DevKit into builder tools #1127

Conversation

fill-the-fill
Copy link
Collaborator

@fill-the-fill fill-the-fill commented Aug 9, 2023

Checklist

Builder Tool addition

  • Title: Yaci DevKit
  • Description: Create your own local Cardano devnet with ease! It includes an Indexer, minimal Explorer interface, and support for Cardano Client Lib or Lucid JS library's Blockfrost provider.
  • Website: Yaci DevKit
  • Getstarted: null
  • Tags:
    • cli
    • testing

@fill-the-fill fill-the-fill added the builder tool Indicates a PR/issue on a builder tool label Aug 9, 2023
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a really good thing 🤓

I wonder about the best criteria for scaling these logos into the image box. Currently this one is rather small compared to the frame & could be increased a bit. But also would be good if it's "magnified" no more than other logos... yet I think making the logos larger on solid colour backgrounds would provide more clarity for the projects & presentation quality for the Portal pages.

@fill-the-fill you are scaling these according to your own impressions & know well how the logos all look in groups, so what are your feelings are about this? 🤔

@fill-the-fill
Copy link
Collaborator Author

Looks like a really good thing 🤓

I wonder about the best criterial for scaling these logos into the image box. Currently it's rather small compared to the frame & could be increased a bit. But also would be good if it's "magnified" no more than other logos... yet I think making the logos larger on solid colour backgrounds would provide more clarity for the projects & presentation quality for the Portal pages.

@fill-the-fill you are scaling these according to your own impressions & know well how the logos all look in groups, so what are your feelings are about this? 🤔

I've scaled the logo for it to fit in the preview image. Since I didn't find any other picture that represents the project I used this one and scaled a bit. But I'm more than open for changes 😊

@rphair
Copy link
Collaborator

rphair commented Aug 9, 2023

IMHO we should MAKE ALL THE THINGS BIGGER 😂 unless there is some typographic usefulness for the white space surrounding web site features 🤓

@fill-the-fill
Copy link
Collaborator Author

IMHO we should MAKE ALL THE THINGS BIGGER 😂 unless there is some typographic usefulness for the white space surrounding web site features 🤓

I could look into that and spend some time adjusting other logos. Maybe you could open an issue (suggestion) and I will take into my hands =)

@rphair
Copy link
Collaborator

rphair commented Aug 9, 2023

sure, I'll have a look next time browsing the listings. There were 1 or 2 contributions where the logo was too small (this is not one of them), or detail in a screenshot was illegible (and therefore also needed to be "zoomed in" somehow), and in my experience we've addressed them in the PRs. If I observe a potential improvement I'll open an issue and maybe GIMP them myself. 😎

@fill-the-fill fill-the-fill merged commit beba602 into cardano-foundation:staging Aug 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder tool Indicates a PR/issue on a builder tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants