-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Yaci DevKit into builder tools #1127
Add Yaci DevKit into builder tools #1127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a really good thing 🤓
I wonder about the best criteria for scaling these logos into the image box. Currently this one is rather small compared to the frame & could be increased a bit. But also would be good if it's "magnified" no more than other logos... yet I think making the logos larger on solid colour backgrounds would provide more clarity for the projects & presentation quality for the Portal pages.
@fill-the-fill you are scaling these according to your own impressions & know well how the logos all look in groups, so what are your feelings are about this? 🤔
I've scaled the logo for it to fit in the preview image. Since I didn't find any other picture that represents the project I used this one and scaled a bit. But I'm more than open for changes 😊 |
IMHO we should MAKE ALL THE THINGS BIGGER 😂 unless there is some typographic usefulness for the white space surrounding web site features 🤓 |
I could look into that and spend some time adjusting other logos. Maybe you could open an issue (suggestion) and I will take into my hands =) |
sure, I'll have a look next time browsing the listings. There were 1 or 2 contributions where the logo was too small (this is not one of them), or detail in a screenshot was illegible (and therefore also needed to be "zoomed in" somehow), and in my experience we've addressed them in the PRs. If I observe a potential improvement I'll open an issue and maybe GIMP them myself. 😎 |
Checklist
yarn build
after adding my changes without getting any errors.Builder Tool addition
cli
testing