Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New weather implementation #2371

Merged
merged 9 commits into from
Jan 20, 2020
Merged

New weather implementation #2371

merged 9 commits into from
Jan 20, 2020

Conversation

Madecu
Copy link
Contributor

@Madecu Madecu commented Jan 20, 2020

Description

  • Added a new script in PythonAPI/util to be able to change the sun position and the weather parameters individually.
  • Activated Mesh Distance Fields.
  • Changed cloudyness for cloudiness.
  • Added three new parameters for the weather (Fog density, Fog distance, and Wetness).
  • New function "SetWeather" in weather.cpp to be able to update the weather parameters without notifying it to the blueprint's event.

Where has this been tested?

  • Platform(s): Windows and Linux
  • Python version(s): Python 3.7
  • Unreal Engine version(s): 4.22

Possible Drawbacks

No drawbacks found yet.


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Jan 20, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes.

@Madecu Madecu added the art Requires changes/additions to art content label Jan 20, 2020
@Madecu Madecu changed the title Marcos/weather New weather implementation Jan 20, 2020
Copy link
Contributor

@marcgpuig marcgpuig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 7 files at r1, 2 of 5 files at r6, 1 of 1 files at r9, 4 of 4 files at r10.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @bernatx)

Copy link
Contributor

@bernatx bernatx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @bernatx)

@bernatx bernatx merged commit 7bd95e4 into master Jan 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the marcos/weather branch January 20, 2020 19:54
@jahaniam
Copy link

jahaniam commented Feb 5, 2020

Mesh Distance Fields was disabled to remove ghosting effect! #1838

@Madecu
Copy link
Contributor Author

Madecu commented Feb 5, 2020

Hi @a-jahani

We decided to enable Mesh Distance Fields again to improve the lighting in our scenes. We still have some ghosting but we managed to minimize it as much as we could. On the other hand, we gain a much better looking with Distance Fields Ambient Occlusion and Distance Fields Shadows combined with Cascade Shadows.
If the ghosting is still an issue, the user can always disable it. We will explain it how in the 0.9.8 release documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
art Requires changes/additions to art content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants