-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New weather implementation #2371
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes. |
Activate mesh distance fields
…ions Weather.cpp --> Skip weather Weather.h --> Added "SetWeather" Function
29d0d6b
to
089ca41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 7 files at r1, 2 of 5 files at r6, 1 of 1 files at r9, 4 of 4 files at r10.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @bernatx)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @bernatx)
Mesh Distance Fields was disabled to remove ghosting effect! #1838 |
Hi @a-jahani We decided to enable Mesh Distance Fields again to improve the lighting in our scenes. We still have some ghosting but we managed to minimize it as much as we could. On the other hand, we gain a much better looking with Distance Fields Ambient Occlusion and Distance Fields Shadows combined with Cascade Shadows. |
Description
cloudyness
forcloudiness
.Where has this been tested?
Possible Drawbacks
No drawbacks found yet.
This change is