Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 4 new attributes to the vehicle blueprints #5258

Merged
merged 9 commits into from
Apr 12, 2022

Conversation

glopezdiest
Copy link
Contributor

@glopezdiest glopezdiest commented Mar 15, 2022

Description

Added 4 new attributes to all vehicles:
- base_type used as a vehicle classification (car, truck, van, motorcycle and bycicle).
- special_type provides more information about the vehicle (currently electric, emergency, taxi, and the rest are empty).
- has_dynamics_doors either true or false, depending on the vehicle being able (or not) to open their doors.
- has_lights either true or false, depending on the vehicle being able (or not) to turn on their lights.

This PR goes hand in hand with another one at our content, where these attribute values are set

The values chosen are as follows:
image

Where has this been tested?

  • Platform(s): Ubuntu 18.04
  • Python version(s): 3.6
  • Unreal Engine version(s): CARLA's 4.26

Possible Drawbacks

None? This just add more functionailities, and removes nothing.


This change is Reviewable

@glopezdiest glopezdiest requested a review from a team as a code owner March 15, 2022 13:47
Axel1092
Axel1092 previously approved these changes Apr 12, 2022
Copy link
Contributor

@Axel1092 Axel1092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @bernatx and @XGodina)

Copy link
Contributor

@Axel1092 Axel1092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @bernatx and @XGodina)

@glopezdiest glopezdiest merged commit c977075 into dev Apr 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the glopez/bp_library_types branch April 12, 2022 13:57
ghost12111 pushed a commit to ghost12111/carla that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants