-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 4 new attributes to the vehicle blueprints #5258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @bernatx and @XGodina)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @bernatx and @XGodina)
* Added 4 new vehicle attributes
Description
Added 4 new attributes to all vehicles:
- base_type used as a vehicle classification (car, truck, van, motorcycle and bycicle).
- special_type provides more information about the vehicle (currently electric, emergency, taxi, and the rest are empty).
- has_dynamics_doors either true or false, depending on the vehicle being able (or not) to open their doors.
- has_lights either true or false, depending on the vehicle being able (or not) to turn on their lights.
This PR goes hand in hand with another one at our content, where these attribute values are set
The values chosen are as follows:
![image](https://user-images.githubusercontent.com/58212725/158392755-f1b4806d-8959-489e-a09d-fb838c1e5112.png)
Where has this been tested?
Possible Drawbacks
None? This just add more functionailities, and removes nothing.
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)