Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various scenario updates #20

Merged
merged 4 commits into from Jan 16, 2019
Merged

Various scenario updates #20

merged 4 commits into from Jan 16, 2019

Conversation

fabianoboril
Copy link
Collaborator

@fabianoboril fabianoboril commented Jan 11, 2019 •
edited by germanros1987

  • Updated all scenarios to use Lincoln MKZ as ego vehicle
  • Removed unnecessary timeouts from scenarios
  • Updated VehicleTurningRight/Left scenarios to sync arrival times
  • Resolved pylint issues

Checklist:

  • Your branch is up-to-date with the master branch and tested with latest changes
  • Extended the README / documentation, if necessary
  • Code compiles correctly and runs
  • Code is formatted and checked with Utilities/code_check_and_formatting.sh

Where has this been tested?

  • Platform(s): Ubuntu 16.04
  • Python version(s): Python 2.7 and 3.5
  • Unreal Engine version(s): 4.19
  • CARLA version: 0.9.2

This change is Reviewable

@fabianoboril
Updated all scenarios to use Lincoln MKZ as ego vehicle
9e04684 
Other changes:
- Fixed output of result_writer.py
- Average velocity criterion is marked as optional in all scenarios

Change-Id: I79fa548f7af693410ed757ffc1f22d13b53b0dd5
@fabianoboril
Updated VehicleTurningRight/Left scenarios to sync arrival times
3e90ed3 
The VehicleTurningRight and VehicleTurningLeft scenarios were updated to
syncronize the arrival times between the ego vehicle and the other
traffic participants, to avoid problems when the ego vehicle is
slower/faster than expected.

Change-Id: I4083c378e5651344cf9c15c3e4cc71b0df2abceb
@fabianoboril
Removed unnecessary timeouts from scenarios
a482de6 
Removed unnecessary timeouts from the following scenarios:
- DynamicObjectCrossing
- NoSignalJunctionCrossing

Change-Id: Ib697d6db6c68affd68d31fb0153ac18278a6db44
@fabianoboril
Resolved pylint issues
d02b8fe 
Change-Id: I47344601b3f55e791c2b655505a979ea1bf9fb98
germanros1987
germanros1987 approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@germanros1987 germanros1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested all the scenarios and the changes work. Good!

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@germanros1987 germanros1987 merged commit 5d5f57e into master Jan 16, 2019
@fabianoboril fabianoboril deleted the fixScenarios branch January 22, 2019 07:41
RuihanGao pushed a commit to RuihanGao/scenario_runner that referenced this pull request Jul 18, 2019
@germanros1987
Merge pull request carla-simulator#20 from carla-simulator/fixScenarios
8dcdf73 
Various scenario updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germanros1987 germanros1987 germanros1987 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabianoboril @germanros1987