-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved reloading of OpenDRIVE maps in OSC #752
Conversation
Before enforcing a reload of the CARLA map when using OpenSCENARIO the currently loaded map is compared with the new map. This comparison was reworked to enforce that both maps start with the '<OpenDRIVE>' start tag. Reworked handling of TrafficManager inside ScenarioRunner to improve startup time. Change-Id: I5d2fac8fcdc9a5bdd7fbb47589f3a1b535188175
0f09fc8
to
cf53d71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 2 of 2 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @fabianoboril and @fpasch)
scenario_runner.py, line 321 at r3 (raw file):
CarlaDataProvider.set_client(self.client)
Not really an issue but we can move this to the init, where the client is created
scenario_runner.py, line 364 at r3 (raw file):
Quoted 5 lines of code…
CarlaDataProvider.set_traffic_manager_port(int(self._args.trafficManagerPort)) tm = self.client.get_trafficmanager(int(self._args.trafficManagerPort)) tm.set_random_device_seed(int(self._args.trafficManagerSeed)) if self._args.sync: tm.set_synchronous_mode(True)
No comments here. However, I saw that we aren't setting the TM to async on cleanup, which we should do definitely do.
cf53d71
to
dc38e96
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @fpasch)
Before enforcing a reload of the CARLA map when using OpenSCENARIO
the currently loaded map is compared with the new map. This comparison
was reworked to enforce that both maps start with the '' start tag:
Reworked handling of TrafficManager inside ScenarioRunner to improve
startup time:
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)