Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iPhone 6 Plus detection incorrect #9

Closed
BlakeLucchesi opened this issue Sep 25, 2014 · 2 comments · Fixed by #10
Closed

iPhone 6 Plus detection incorrect #9

BlakeLucchesi opened this issue Sep 25, 2014 · 2 comments · Fixed by #10

Comments

@BlakeLucchesi
Copy link
Contributor

The macro to determine whether the device is an iPhone 6+ is incorrectly calculated. The size should test for a bounds height of 736.0f. The iPhone 6+ virtual pixel resolution is 2208px x 1242px and it runs at @3x retina. Therefore:

2208 / 3 = 736.

Pull request coming...
@BlakeLucchesi BlakeLucchesi mentioned this issue Sep 25, 2014
Merged
@BlakeLucchesi
Copy link
Contributor Author

Also, I tested this on a 6+ device and it worked.

@carlj carlj closed this as completed in #10 Sep 25, 2014
@carlj
Copy link
Owner

carlj commented Oct 6, 2014

@BlakeLucchesi FYI: #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust bounds height detection for iPhone 6+ BlakeLucchesi/CJAMacros
2 participants
@BlakeLucchesi @carlj