Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean capability required #1

Closed
russel opened this issue Dec 28, 2012 · 2 comments
Closed

Clean capability required #1

russel opened this issue Dec 28, 2012 · 2 comments

Comments

@russel
Copy link
Contributor

russel commented Dec 28, 2012

There needs to be a clean capability as well as a build capability.

I have forked the repository (https://github.com/russel/dlang-workspace) and have trialled two variants as different branches:

  1. Turn the repository into a submodules ones and add clean capability to the system (submodules).
  2. Allow the script to deal with symbolic links instead of directories (script-edit).

The Phobos build make specific assumptions that cannot be satisfied using 2, which is a real shame?

If either of these two approaches are seen as positive contributions to the project I can create a pull request.

@carlor
Copy link
Owner

carlor commented Jan 2, 2013

@russel I've merged the second branch, thanks for your contribution!

@carlor carlor closed this as completed Jan 2, 2013
@russel
Copy link
Contributor Author

russel commented Jan 2, 2013

I merged the mainline master into my repository and then merged it into my submodules branch, fixing the merge conflicts, and it all works fine.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants