"shouldExtend" assertion not applying to classes that do not have parent class

[lorenzodalaqua]

Question
Hi, I am unsure whether this is a bug or intended behavior, so I decided to post this as a question first.

I am planning to use PHPat for enforcing classes in certain namespaces in the application I am working on extend a common base class. (e.g. all controllers should extend BaseController, all requests should extend BaseRequest, etc)

The rule I am using is this, where $namespace is a namespace where we want to enforce a common base class for all classes, and $baseClass is the class which should be extended:

PHPat::rule()
    ->classes(Selector::namespace($namespace))
    ->excluding(Selector::classname($baseClass))
    ->shouldExtend()
    ->classes(Selector::classname($baseClass));

This works fine and PHPat correctly identifies an error for classes that extend an invalid base class, e.g. like the class below:

class InvalidRequest extends NotTheExpectedBaseRequest {}

But no errors are reported if we run PHPAt for classes with no extends statement such as this one:

class InvalidRequest {}

Now I am left wondering, is this the intended behavior, a bug, or have I missed something when configuring the rule for enforcing this? 🤔

Thanks in advance for your time! 😄

[carlosas]

This is definitely a bug 😱

I made a quick fix in the branch fix-should-empty that should be accessible via:

"require-dev": {
    "phpat/phpat": "dev-fix-should-empty",
...

plus composer update phpat/phpat

If you can check the fix against your code, it would be very helpful. Also I will double check tomorrow ASAP and release it.

Thanks for the report

[lorenzodalaqua]

Hi, thanks for your quick response to this.

I tested using the fix-should-empty branch and errors are identified when the class has no parent now 👍

I will just wait for the release so I can upgrade the package then, thanks!

[carlosas]

Released in https://github.com/carlosas/phpat/releases/tag/0.10.8 🚀