Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StatementBuilder & Parser return type mismatch #36

Closed
j6s opened this issue Nov 13, 2019 · 1 comment
Closed

StatementBuilder & Parser return type mismatch #36

j6s opened this issue Nov 13, 2019 · 1 comment
Assignees
@carlosas
Labels
bug Something isn't working

Comments

@j6s
Copy link
Contributor

j6s commented Nov 13, 2019

Bug Description
The return type of StatementBuilder#parseFile is declared as array, but the underlying method Parser#parse may return null.

This may result in type errors down the road.
@j6s j6s added the bug Something isn't working label Nov 13, 2019
@carlosas
Copy link
Owner

carlosas commented Nov 23, 2019 •
edited
Loading

done in 813c551

I also set a task to convert it in a warning event.
Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlosas carlosas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@j6s @carlosas