Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform parameter gets reset to default value when editing the step #39

Closed
pawlos opened this issue Sep 16, 2018 · 9 comments
Closed

Comments

@pawlos
Copy link

pawlos commented Sep 16, 2018

The plugin works fine with one exception that I've observed.

Whenever I set the platform parameter to be x86 and then edit the step the value is being reset to AnyCPU/MSIL. But when I check the HTML for this dropdown the selected attribute is set correctly on x86.

Haven't observed anything like that on any other plugins but not sure if this is only xUnit-TeamCity plugin related.

TC version: 2018.1.2 (build 58537)
Plugin version: 1.2.1-3-g59671cf

It looks like the same behavior is with Version parameter.
Let me know if more info is needed.

@tomaszprasolek
Copy link

I also have that problem.

TeamCity: 2018.1.2 (build 58537)
xUnit Plugin: 1.2.1-3-g59671cf

@tomaszprasolek
Copy link

In TeamCity 2018.1.3 still is that bug.

@pawlos
Copy link
Author

pawlos commented Nov 2, 2018

I think the problem is in the plugin. I've tried looking at this issue for some time but didn't see anything obvious there.

@carlpett
Copy link
Owner

carlpett commented Nov 2, 2018

Hey,
Sorry for the lack of activity here. I don't have an environment to test in at the moment, but I'll see if I can set one up.
Do any of you know if this stopped working in new versions of TC? I do think it used to work, but it is quite possible there have been breaking changes in TC since then.

@carlpett
Copy link
Owner

carlpett commented Nov 2, 2018

Found the problem now, looks like some of the javascript in the plugin doesn't work any more.

@pawlos
Copy link
Author

pawlos commented Nov 8, 2018

@carlpett thanks for the fix. Will there be any release soon or can I somehow download the package with the fix from CircleCI?

@carlpett
Copy link
Owner

carlpett commented Nov 8, 2018

I was hoping to get a fix for #38 in too in the next release, but if I don't find time before the end of the week to fix that I'll just release this.
Sounds good?

@pawlos
Copy link
Author

pawlos commented Nov 8, 2018

Yup. Perfect!

@tomaszprasolek
Copy link

I've updated the plugin. It works. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants