Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin paho-mqtt version < 2.0.0 #1065

Merged
merged 1 commit into from Feb 21, 2024
Merged

Pin paho-mqtt version < 2.0.0 #1065

merged 1 commit into from Feb 21, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented Feb 21, 2024

Description:

Related issue (if applicable): n/a

MQTT v2 appears to be non-backwards-compatible with it's predecessor. This is causing the following error to appear in a lot of new services that require it.

Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/paho/mqtt/client.py", line 874, in del
self._reset_sockets()
File "/usr/local/lib/python3.8/site-packages/paho/mqtt/client.py", line 1133, in _reset_sockets
self._sock_close()
File "/usr/local/lib/python3.8/site-packages/paho/mqtt/client.py", line 1119, in _sock_close
if not self._sock:
AttributeError: 'Client' object has no attribute '_sock'

Apprise has been reported to be impacted here . Best work-around would be to make sure systems do not leverage the new paho-mqtt version; the official bug report is here: eclipse/paho-mqtt/814

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@mqtt-avoid-v2-for-now

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "mqtt://credentials"

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5de9b7b) 99.27% compared to head (d46f625) 99.27%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1065   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files         136      136           
  Lines       17738    17738           
  Branches     3618     3618           
=======================================
  Hits        17610    17610           
  Misses        119      119           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants