Refactored configuration + cache support added #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 68 68
Lines 7753 7801 +48
Branches 1244 1253 +9
=====================================
+ Hits 7753 7801 +48
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Re-factored some of the AppriseConfig class to additionally support the
cache=directive similar to how it works with Attachments. The idea is now you can tell Apprise not to cache the configuration files (which will cause them to retrieved each request made). This provides a more dynamic solution allowing your configuration to change while Apprise has already been loaded in memory.For web requests, you can set things like
cache=30which will keep the last retrieved remote content for 30 seconds. All requests made within this time period will use the same configuration retrieved from that one remote request. After 30 seconds (in the case of this example) a new remote fetch for configuration is made (renewing it).The default option is
cache=Yeswhich causes Apprise to continue to behave as it had in the past; after a remote request for configuration has been made, it is re-used for the entire life of the program; no further requests are made.You can also set
cache=Noto disable caching all together. This has a bit of overhead involved; but this might be your intention. Apprise URLs are queried from configuration files (regardless of where they are) each and every time.Checklist
flake8)