Tests: Use global no_throttling_everywhere fixture
#701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of needing to individually disable throttling on a per-plugin basis, this fixture takes care of all notifiers in `NOTIFY_MODULE_MAP` automatically. With `autouse=True`, there is no need to activate it manually.
amotl
force-pushed
the
amo/tests-no-throttling
branch
from
895c1ff
to
c9f8cae
Compare
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #701 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 113 113
Lines 14532 14532
Branches 2959 2959
=========================================
Hits 14532 14532 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
amotl
commented
Oct 15, 2022
Comment on lines
-36
to
+43
| @pytest.fixture | ||
| def no_throttling(): | ||
| @pytest.fixture(scope="session", autouse=True) | ||
| def no_throttling_everywhere(session_mocker): | ||
| """ | ||
| A pytest fixture which disables Apprise throttling. | ||
| A pytest session fixture which disables throttling on all notifiers. | ||
| It is automatically enabled. | ||
| """ | ||
| backup = {} | ||
| backup["NotifyBase"] = NotifyBase.request_rate_per_sec | ||
| backup["NotifyPushBullet"] = NotifyPushBullet.request_rate_per_sec | ||
| NotifyBase.request_rate_per_sec = 0 | ||
| NotifyPushBullet.request_rate_per_sec = 0 | ||
| yield | ||
| NotifyBase.request_rate_per_sec = backup["NotifyBase"] | ||
| NotifyPushBullet.request_rate_per_sec = backup["NotifyPushBullet"] | ||
| for notifier in NOTIFY_MODULE_MAP.values(): | ||
| plugin = notifier["plugin"] | ||
| session_mocker.patch.object(plugin, "request_rate_per_sec", 0) |
There was a problem hiding this comment.
I think this makes a dream come true? Thanks for insisting to steward me into this direction. It is rather heavy, yet beautiful. I like it.
amotl
added a commit
to panodata/apprise
that referenced
this pull request
Oct 17, 2022
Instead of needing to individually disable throttling on a per-plugin basis, this fixture takes care of all notifiers in `NOTIFY_MODULE_MAP` automatically. With `autouse=True`, there is no need to activate it manually.
amotl
added a commit
to panodata/apprise
that referenced
this pull request
Oct 18, 2022
Instead of needing to individually disable throttling on a per-plugin basis, this fixture takes care of all notifiers in `NOTIFY_MODULE_MAP` automatically. With `autouse=True`, there is no need to activate it manually.
amotl
added a commit
to panodata/apprise
that referenced
this pull request
Oct 18, 2022
Instead of needing to individually disable throttling on a per-plugin basis, this fixture takes care of all notifiers in `NOTIFY_MODULE_MAP` automatically. With `autouse=True`, there is no need to activate it manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#687 added a
no_throttlingfunction-scoped fixture, which needed to be individually attached to specific test cases.Instead of needing to individually disable throttling on a per-plugin basis, the new
no_throttling_everywheresession-scoped fixture takes care of all notifiers inNOTIFY_MODULE_MAPautomatically. Withautouse=True, there is no need to activate it manually.I've broke this away from #689, in order to make the review of each patch a bit easier.