Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to register service to Orion Server #171

Open
cs-lexliu opened this issue Feb 18, 2022 · 0 comments
Open

Unable to register service to Orion Server #171

cs-lexliu opened this issue Feb 18, 2022 · 0 comments

Comments

@cs-lexliu
Copy link
Contributor

Context

The grpc.ServiceDesc has been exported from protoc-gen-go-grpc v1.1.0. The protoc-gen-orion generates the file that contains an unresolved reference to the unexported name of service desc.

Process

Use the Orion example.

Execute protoc -I. --go-grpc_out=. --go_out=. --orion_out=. simple.proto.

Environment

go version         1.17.6
protoc-gen-go-grpc v1.2.0
protoc-gen-orion   latest
protoc-gen-go      v1.27.1

Expected result

The simple service should be registered in Orion Serve, and simple_proto/simple.proto.orion.pb.go should not contain any error.

Current result

In simple_proto/simple.proto.orion.pb.go, we got a following error.

Unresolved reference '_SimpleService_serviceDesc'

Possible Fix

Follow the protoc-gen-go-grpc naming role in grpc/grpc-go#4035.
And modify the generating code.

serviceDescVar := "_" + servName + "_serviceDesc"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant