Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020-11-2: French – Bring French definitions in-line with English changes in PR #187: General editing and corrections #195

Closed
baileythegreen opened this issue Nov 2, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@baileythegreen
Copy link
Contributor

To be assigned to @baileythegreen.

In PR #187 several English definitions were corrected, clarified, or generalised, but translations of these often propagate the errors from the English. I will do a first-pass at updating these.

@MarieHouillon
Copy link
Contributor

Hello,

As a native French speaker, I propose to review the French glossary.

I have a first pull request to propose: "Variable arguments" was translated by "arguments d'une variable", which is inaccurate. I also added some information from the English definition.

If it is fine that I review the French glossary, should I propose one pull request per modified definition, or rather gathering several in a same pull request ?

@fmichonneau
Copy link
Contributor

Hi @MarieHouillon,

Thanks for volunteering to help with this project. In general, we prefer one or a small number of changes per pull request. However, for edits to existing text, it's OK to create larger pull requests.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants