-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for setting up Python through renv #448
base: main
Are you sure you want to change the base?
Conversation
Workaround for rstudio/renv#1217
Avoids some undesirable renv side effects.
@milanmlft, THANK YOU SO MUCH FOR THIS PR! To manage expectations: I (at the moment, the sole maintainer) am quite overencumbered right now and will not be able to review this until mid-June 😞 That being said, I can see this being a real boon to some of our python lessons! I'm really happy that you've written the tests, functionality, and created a working demo 🤩. One comment I can make right now WRT to the actions: in carpentries/actions@3532acf, instead of doing this, you can set Additionally, I think this is something @sabaferdous12 might be interested in. |
/document |
Hi @zkamvar, thanks for the nice feedback! And no worries about the review. For my own purposes, I can continue with my own fork for now. If anything else pops up, I'll add it here as well. One problem I currently still have is that Another note is the bug reported in rstudio/renv#1217, for which I implemented a workaround in 1495f89. Oh and coincidentally, I'm actually working together with @sabaferdous12 on a project, which is exactly why I implemented this 😅 |
There are some test failures here, but that's because they need to be skipped on Windows by the fact that the earlier context skips them on Windows. I'm still working on the documentation for contributors, but see here about tests: #455 (comment) I believe these are skipped on Windows because of the idiosyncracies with using {renv} on the windows runner (though I know it works well on Windows) |
Alright, I'll adapt the tests accordingly. I'm still doing some work on the tests anyway because I'm not entirely happy with them yet. I'll push some more updates in the coming days! |
Awesome! Also FYI (and for @sabaferdous12), #465 modifies the |
[pull] main from carpentries:main
[pull] main from carpentries:main
[pull] main from carpentries:main
[pull] main from carpentries:main
[pull] main from carpentries:main
Correctly check for lines in `requirements.txt`
Pinging the current
If there's anything I can do to speed up the process, please let me know! |
[pull] main from carpentries:main
[pull] main from carpentries:main
[pull] main from carpentries:main
[pull] main from carpentries:main
[pull] main from carpentries:main
[pull] main from carpentries:main
Hi sandpaper devs!
I have been experimenting with ways to set up Python and manage Python dependencies in sandpaper lessons through
renv::use_python()
. This is mainly geared towards running Python code chunks in RMarkdown files.To see this in action, I set up a toy sandpaper lesson here: https://github.com/milanmlft/toy-sandpaper-python
Note that I also had to update the carpentries GitHub Actions slightly to get this to work: https://github.com/milanmlft/actions. If relevant, I can create a PR for that as well.
I thought this might be useful for other sandpaper users and would love to get your feedback!
This would also address #61 (I think).