-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDP and hydra model #51
Labels
bug
Something isn't working
Comments
Hmm I'll look into it. I've only been testing with deepspeed. Is there ever a reason we would want to use ddp vs deepspeed? |
I'm not sure there's a need for DDP |
I would say lets close this issue. I don't think DDP is worth the effort. |
Let's just make clear we only support deepspeed. |
Ok so I think the solution is to update the readme/docs and leave it at that. Lets close this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Describe the bug
Hydra model doesn't play nicely with ddp
accelerate launch --num_processes 2 --num_machines 1 --config_file ddp.yaml examples/ppo_sentiments.py
This is a relevant discussion
pytorch/pytorch#43259
Which trlX version are you using?
stage-api @ 8057d16
Additional system and package information
No response
The text was updated successfully, but these errors were encountered: