Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont mangle key typos. #104

Closed
aaroncrespo opened this issue May 11, 2017 · 4 comments
Closed

Dont mangle key typos. #104

aaroncrespo opened this issue May 11, 2017 · 4 comments

Comments

@aaroncrespo
Copy link

aaroncrespo commented May 11, 2017

Carthage/Carthage#1926

I think for the sake of better error messages Commandant should not try and convert flags to a set

It will mangle a --key typo and produce confusing errors.

If flags are passed as used ex:

$ carthage update -platform
Unrecognized arguments: -armpfolt

Should become

$ carthage update -platform
Unrecognized arguments: -platform
@mdiep
Copy link
Member

mdiep commented May 11, 2017

That's only done if there's a single -, which denotes a single-letter flag/argument. That's how basically all *nix tools work.

@mdiep mdiep closed this as completed May 11, 2017
@aaroncrespo
Copy link
Author

aaroncrespo commented May 11, 2017

do all nix tools randomly reorder the input in the error message?

@aaroncrespo
Copy link
Author

This issue isn't about the fact that there is an error message. this issue is about the formatting and content of the error message.

@mdiep
Copy link
Member

mdiep commented May 11, 2017

It looks like most tools bail on the first unknown option:

$ python -asenxtaboe 
Unknown option: -a

I'm not sure if that's better as it gives you less information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants