-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish mac darwin compatible binaries #218
Comments
Thanks for surfacing this. I think you're right and that all we'd have to do is update our homebrew formulas. Ideally, we'll automate this so it doesn't add ongoing toil. I created a couple of issues in that repo to address this work. For now, we can keep this issue open to increase visibility on this. |
Also, the install script currently selects the AMD64-targeted version of our tools... Let's update that script as part of this work as well so that if you install on an M1, you get ARM64 binaries through all install paths. |
Added a Apple Silicon-targeted version for our latest release. There is a PR updating our scripts to do this for future releases. Made a PR to |
imgpkg and kbld next release will generate a mac arm binary See the below PRs for details The next time an imgpkg or kbld release occurs, in addition to modifying the homebrew formula and install.sh with the new version and sha, a change to also include the mac arm binary will need to be made (similar to the PR made above by @100mik) I'm not sure how to best capture this 'one-off' release step. |
@DennisDenuto note the list of issues in the description ... there's one for each tool, respectively... is that a good place to capture the release step? |
Yes I think so. However when a release is being performed (in the future), I think ultimately, the person conducting the release will need to remember to also make additional updates to the homebrew formula and install.sh (which are in separate repos). |
brew install vmware-tanzu/carvel/kwt |
Thanks, @vangie. We haven't yet updated kwt's build process but have an issue tracked here: carvel-dev/kwt#28. I'll drop a mention in our slack channel just so that folks are aware and in case someone has bandwidth to knock this out. As always, PRs are welcome :) |
What steps did you take:
on OS X,
MacBook Air (M1, 2020)
... big surprobably an easy fix, just need to support arm64 i think in the brew publication process?
What happened:
looks like the 64 intel brew is the only one supported?
What did you expect:
carvel would install on an m1 mac...
(edit: add summary of issues to implement this.)
Related work:
The text was updated successfully, but these errors were encountered: