Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support managed identities to pull image bundle from remote private docker repository #1572

Open
leonard520 opened this issue May 24, 2024 · 2 comments
Assignees
Labels
discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution enhancement This issue is a feature request

Comments

@leonard520
Copy link

Describe the problem/challenge you have

Currently, kapp needs a image pull secret to pull image bundle from remote private docker repository. However, it is not secure to use a secret to store credentials in k8s cluster.

I think passwordless is a better solution. E.g. in Azure, I would like to use managed identities. In this way, I don't need to handle credentials store and rotation.

Describe the solution you'd like

Actually there is some other project doing similar features. E.g. kpack has integrated with ACR key chain to get docker credential on demand.

Another project is doing similar thing. azure_credentials support GetCredentials through cloud provider interface.

Anything else you would like to add:

N/A


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@leonard520 leonard520 added carvel-triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels May 24, 2024
@leonard520 leonard520 changed the title Support Support managed identities to pull image bundle from remote private docker repository May 24, 2024
@renuy renuy added discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution and removed carvel-triage This issue has not yet been reviewed for validity labels May 31, 2024
@100mik
Copy link
Contributor

100mik commented Jun 6, 2024

kapp-controller today will pick up credentials from the ACR keychain if the Kubernetes cluster is attached to an ACR registry.

Are your observations saying otherwise?
I believe all you need to do is documented here

@100mik 100mik self-assigned this Jun 6, 2024
@leonard520
Copy link
Author

@100mik Let me clarify my question. From my understanding, when kapp-controller try to reconcile a packageinstall, it request a secret contains the credential to the repo to pull the image/imagebundle. User can provide the image pull secret in package install or leverage secretgen-controller.

func (pi *PackageInstallCR) reconcileFetchPlaceholderSecrets(pkg datapkgingv1alpha1.Package) (datapkgingv1alpha1.Package, error) {

I am wondering if we can elimiate this credential? I am not able to find the code that leverage ACR keychain in code path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution enhancement This issue is a feature request
Projects
Status: No status
Development

No branches or pull requests

3 participants