-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete multiple deployments simultaneously via single kapp delete cmd #50
Comments
the alternative option is to disallow multiple -a specifications. im not sure if we should allow multiple -a on delete as then deploy command becomes asymmetric with delete. thoughts about alternative mentioned above? |
Cobra doesn't make this easy |
can just switch to string slice type and assert on length == 1. |
The docs for the command will then be misleading as they will show the flag as an array. Also, this pattern applies to every other flag. I'd leave it alone and let Cobra manage the behavior generically. |
but if so, what does it mean to kapp deploy -a foo -a another-one ...? |
after thinking some more, i think at this point kapp should stick with one deployment for -a flag for now to maintain consistency with other commands. |
It would be nice to delete multiple deployment with a single command
Currently, only the last app (app3) is deleted and the others are ignored. This is common behavior with cobra, but can be surprising for users.
The text was updated successfully, but these errors were encountered: