Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kapp gets confused when ordering of fields isn't deterministic #705

Closed
voor opened this issue Feb 10, 2023 · 1 comment
Closed

kapp gets confused when ordering of fields isn't deterministic #705

voor opened this issue Feb 10, 2023 · 1 comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome.

Comments

@voor
Copy link

voor commented Feb 10, 2023

What steps did you take:
Some custom resources, like for example AWSCluster in Cluster API AWS, do not guarantee consistent ordering of entries. This causes kapp to fail in validating whether something truly needs to be updated.

What happened:
Given an array:

1
2
3

if that array is somehow changed in order:

3
2
1

then kapp will believe that the array has changed, and make updates accordingly.

What did you expect:
Since array ordering is actually a modification, this issue might be very difficult to truly tackle, so I reckon kapp thinking the object has changed is the intended result.

Anything else you would like to add:
Maybe the real problem here is that there needs to be a rebase rule to say an array's ordering isn't important, which would be nondefault behavior?

Environment:

  • kapp version (use kapp --version):
  • OS (e.g. from /etc/os-release):
  • Kubernetes version (use kubectl version)

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@voor voor added bug This issue describes a defect or unexpected behavior carvel triage This issue has not yet been reviewed for validity labels Feb 10, 2023
@praveenrewar praveenrewar added enhancement This issue is a feature request carvel accepted This issue should be considered for future work and that the triage process has been completed priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome. and removed bug This issue describes a defect or unexpected behavior carvel triage This issue has not yet been reviewed for validity labels Feb 14, 2023
@voor
Copy link
Author

voor commented May 22, 2023

Closing this issue as it's fairly stale and unique to that given scenario.

@voor voor closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome.
Projects
Archived in project
Development

No branches or pull requests

2 participants