Vendir allows self-destructing configuration

[Zebradil]

What steps did you take:

Try to run vendir sync with a config that contains a directory path with .., like this (the charts directory must exist beforehand):

apiVersion: vendir.k14s.io/v1alpha1
kind: Config
directories:
  - path: charts/..
    contents:
      - path: foo
        inline:
          paths:
            test.txt: hello world

What happened:

All files from the current directory are gone.

❯ vendir sync
Fetching: charts/.. + foo (inline)

vendir: Error: Syncing directory 'charts/..':
  Deleting dir charts/..: unlinkat charts/..: directory not empty

❯ ls -la | wc -l
0

What did you expect:

I expect vendir to complain about the faulty configuration, like it does for the . path:

❯ cat <<EOF | vendir sync -f-
apiVersion: vendir.k14s.io/v1alpha1
kind: Config
directories:
  - path: .
    contents:
      - path: foo
        inline:
          paths:
            test.txt: hello world
EOF
vendir: Error: Parsing resource config '-':
  Unmarshaling config:
    Validating config:
      Validating directory '.' (0):
        Expected path to not be one of '/', '.', '..', ''

Environment:

• vendir version: 0.38.0
• OS: latest Arch Linux x86_64

---

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

[kumaritanushree]

@Zebradil thank you for raising this issue and adding changes to fix it in PR #341

[kumaritanushree]

@Zebradil I am getting different than error what you have added for the 1st case.

$ mkdir charts

$ ./vendir sync 
Fetching: . + foo (inline)

vendir: Error: Syncing directory '.':
  Deleting dir .:
    RemoveAll .: invalid argument 

$ cat vendir.yml 
apiVersion: vendir.k14s.io/v1alpha1
kind: Config
directories:
  - path: charts/..
    contents:
      - path: foo
        inline:
          paths:
            test.txt: hello world

Can you please check on this or am I doing anything wrong?

[Zebradil]

@kumaritanushree which vendir version are you using? With 0.38.0 I have the following output:

$ mkdir charts
$ cat <<EOF | vendir sync -f-
apiVersion: vendir.k14s.io/v1alpha1
kind: Config
directories:
  - path: charts/..
    contents:
      - path: foo
        inline:
          paths:
            test.txt: hello world
EOF
Fetching: charts/.. + foo (inline)

vendir: Error: Syncing directory 'charts/..':
  Deleting dir charts/..: unlinkat charts/..: directory not empty

Notice the Fetching: line. In your case, it references the . dir that is not presented in the configuration. It looks concerning.

[kumaritanushree]

@Zebradil My bad yes without your changes getting same what I have pasted above but with your change I am getting this error:

Fetching: . + foo (inline)

vendir: Error: Syncing directory '.':
  Deleting dir .:
    RemoveAll .: invalid argument

What I expect is this should show error something like charts/.. is invalid config, it will delete all content of your current directory(can try to think something better).

Although it is not deleting now the content of current directory but error message I feel we can try to make better.