Adding the ability to configure imgpkg timeout #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopapereira
requested changes
Jan 5, 2024
alexbarbato
force-pushed
the
329-tag-timeout
branch
2 times, most recently
from
fc9097f
to
3c6c1c7
Compare
|
Doh, i do that everytime. Thanks! Updated @joaopapereira |
|
@alexbarbato The DCO check is still failing 😅 |
Signed-off-by: Alex Barbato <alex.j.barbato@gmail.com>
alexbarbato
force-pushed
the
329-tag-timeout
branch
from
3c6c1c7
to
59af189
Compare
@joaopapereira trying to trick me :P I think it's Should work now, but please let me know if I'm still goofing something up! |
Lol, yes, it should be |
|
@joaopapereira anything you need here to merge? |
joaopapereira
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
LGTM.
We will need a PR in https://github.com/carvel-dev/carvel/ to add the new field to the documentation
renovate bot
added a commit
to mykso/myks
that referenced
this pull request
Feb 20, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [carvel-dev/vendir](https://togithub.com/carvel-dev/vendir) | minor | `v0.39.0` -> `v0.40.0` | --- ### Release Notes <details> <summary>carvel-dev/vendir (carvel-dev/vendir)</summary> ### [`v0.40.0`](https://togithub.com/carvel-dev/vendir/releases/tag/v0.40.0) [Compare Source](https://togithub.com/carvel-dev/vendir/compare/v0.39.0...v0.40.0) <details> <summary><h2>Installation and signature verification</h2></summary> ##### Installation ##### By downloading binary from the release For instance, if you are using Linux on an AMD64 architecture: ```shell ### Download the binary curl -LO https://github.com/carvel-dev/vendir/releases/download/v0.40.0/vendir-linux-amd64 ### Move the binary in to your PATH mv vendir-linux-amd64 /usr/local/bin/vendir ### Make the binary executable chmod +x /usr/local/bin/vendir ``` ##### Via Homebrew (macOS or Linux) ```shell $ brew tap carvel-dev/carvel $ brew install vendir $ vendir version ``` ##### Verify checksums file signature Install cosign on your system https://docs.sigstore.dev/system_config/installation/ The checksums file provided within the artifacts attached to this release is signed using [Cosign](https://docs.sigstore.dev/cosign/overview/) with GitHub OIDC. To validate the signature of this file, run the following commands: ```shell ### Download the checksums file, certificate and signature curl -LO https://github.com/carvel-dev/vendir/releases/download/v0.40.0/checksums.txt curl -LO https://github.com/carvel-dev/vendir/releases/download/v0.40.0/checksums.txt.pem curl -LO https://github.com/carvel-dev/vendir/releases/download/v0.40.0/checksums.txt.sig ### Verify the checksums file cosign verify-blob checksums.txt \ --certificate checksums.txt.pem \ --signature checksums.txt.sig \ --certificate-identity-regexp=https://github.com/carvel-dev \ --certificate-oidc-issuer=https://token.actions.githubusercontent.com ``` ##### Verify binary integrity To verify the integrity of the downloaded binary, you can utilize the checksums file after having validated its signature. ```shell ### Verify the binary using the checksums file sha256sum -c checksums.txt --ignore-missing ``` </details> ### ✨ What's new * Fix codegeneration * Force usage of Basic Auth when retrieving repositories from git when a flag is configured #​361 * Enforce timeout when retrieving tags from a registry #​329 * Normalize paths provided in the configuration file #​341 * Do not allow overlapping paths #​343 #### New Contributors * @​alexbarbato made their first contributi[carvel-dev/vendir#344 **Full Changelog**: carvel-dev/vendir@v0.39.0...v0.40.0 ### 📂 Files Checksum 0bf3840619436908b11fce2c7015d928450b41a3b9ef19fecc6223ff2ed084a4 ./vendir-darwin-amd64 1b8e5eea893f78ed04b6834f24e1a69bbc9259cd7662bd7fe11283cdf8c482d0 ./vendir-windows-amd64.exe 3e076a452d88d6e3bc190d527f4d7c949ab6eccae19bf5d3cbb910d53724f2b9 ./vendir-linux-amd64 b6defba97d36e26e02df8b263de17061bbbc432365c9d26070eb7a837d7e33fc ./vendir-darwin-arm64 c43469a085dd0f6cebdab97a7747710f9dafa4886dd5e0ae7c1d3f975a12756e ./vendir-linux-arm64 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/mykso/myks). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
added a commit
to mykso/myks
that referenced
this pull request
Feb 20, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [carvel.dev/vendir](https://togithub.com/carvel-dev/vendir) | `v0.39.0` -> `v0.40.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>carvel-dev/vendir (carvel.dev/vendir)</summary> ### [`v0.40.0`](https://togithub.com/carvel-dev/vendir/releases/tag/v0.40.0) [Compare Source](https://togithub.com/carvel-dev/vendir/compare/v0.39.0...v0.40.0) <details> <summary><h2>Installation and signature verification</h2></summary> ##### Installation ##### By downloading binary from the release For instance, if you are using Linux on an AMD64 architecture: ```shell ### Download the binary curl -LO https://github.com/carvel-dev/vendir/releases/download/v0.40.0/vendir-linux-amd64 ### Move the binary in to your PATH mv vendir-linux-amd64 /usr/local/bin/vendir ### Make the binary executable chmod +x /usr/local/bin/vendir ``` ##### Via Homebrew (macOS or Linux) ```shell $ brew tap carvel-dev/carvel $ brew install vendir $ vendir version ``` ##### Verify checksums file signature Install cosign on your system https://docs.sigstore.dev/system_config/installation/ The checksums file provided within the artifacts attached to this release is signed using [Cosign](https://docs.sigstore.dev/cosign/overview/) with GitHub OIDC. To validate the signature of this file, run the following commands: ```shell ### Download the checksums file, certificate and signature curl -LO https://github.com/carvel-dev/vendir/releases/download/v0.40.0/checksums.txt curl -LO https://github.com/carvel-dev/vendir/releases/download/v0.40.0/checksums.txt.pem curl -LO https://github.com/carvel-dev/vendir/releases/download/v0.40.0/checksums.txt.sig ### Verify the checksums file cosign verify-blob checksums.txt \ --certificate checksums.txt.pem \ --signature checksums.txt.sig \ --certificate-identity-regexp=https://github.com/carvel-dev \ --certificate-oidc-issuer=https://token.actions.githubusercontent.com ``` ##### Verify binary integrity To verify the integrity of the downloaded binary, you can utilize the checksums file after having validated its signature. ```shell ### Verify the binary using the checksums file sha256sum -c checksums.txt --ignore-missing ``` </details> ### ✨ What's new * Fix codegeneration * Force usage of Basic Auth when retrieving repositories from git when a flag is configured #​361 * Enforce timeout when retrieving tags from a registry #​329 * Normalize paths provided in the configuration file #​341 * Do not allow overlapping paths #​343 #### New Contributors * @​alexbarbato made their first contributi[carvel-dev/vendir#344 **Full Changelog**: carvel-dev/vendir@v0.39.0...v0.40.0 ### 📂 Files Checksum 0bf3840619436908b11fce2c7015d928450b41a3b9ef19fecc6223ff2ed084a4 ./vendir-darwin-amd64 1b8e5eea893f78ed04b6834f24e1a69bbc9259cd7662bd7fe11283cdf8c482d0 ./vendir-windows-amd64.exe 3e076a452d88d6e3bc190d527f4d7c949ab6eccae19bf5d3cbb910d53724f2b9 ./vendir-linux-amd64 b6defba97d36e26e02df8b263de17061bbbc432365c9d26070eb7a837d7e33fc ./vendir-darwin-arm64 c43469a085dd0f6cebdab97a7747710f9dafa4886dd5e0ae7c1d3f975a12756e ./vendir-linux-arm64 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/mykso/myks). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially closes #329
Looking for feedback if this solution doesn't appear right to you all. Thanks!