Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

objectRepresentationWithDictionary方法名的理由 #7

Closed
DamianSheldon opened this issue Oct 18, 2015 · 2 comments
Closed

objectRepresentationWithDictionary方法名的理由 #7

DamianSheldon opened this issue Oct 18, 2015 · 2 comments

Comments

@DamianSheldon
Copy link
Contributor

从CTPersistanceRecordProtocol文件的的声明config your record with dictionary和CTPersistanceRecord的实现来看这个方法都偏向于是一个动作，是不是名称改成- (void)setPersistanceValuesForKeysWithDictionary:(NSDictionary *)keyedValues会更合适？还是这里这么命名是有其他深层的原因？
@casatwy
Copy link
Owner

casatwy commented Oct 19, 2015

嗯，取名objectRepresentation..是早期希望这是个类方法，直接返回一个类实例的，但因为VirtualRecord本身并不是一个类，所以这个命名就这么迁移过来了，没愿意去改～

@DamianSheldon
Copy link
Contributor Author

哦，原来如此，里面确实还有不少方法名有类似历史问题，维护开源库不容易，有时间我也要加入进来，辛苦了，谢谢！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@casatwy @DamianSheldon