-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] White space is included in policy effect in preview branch #263
Comments
@AsakusaRinne plz see the supported comment format in Golang, I'm not sure if this inline comment is supported or not. |
@AsakusaRinne is this issue the same one as: #258 ? Why open two duplicated issues? |
Not really, #258 is the lack of process of comment symbol, while this issue is raised because the expression includes white symbol. I agree that they are similar, I would like to solve it with #258 in the same PR if it's indeed an unexpected behavior. |
@AsakusaRinne I agree with you, and both are commenting style problems. For this issue my comment is already offered at: #262 (comment) . They can be tackled in one PR. |
Fixed by #262 |
The environment
In branch preview, windows 11, .NET 6
The description
In the preview branch, the loaded policy effect includes white space, while the
PermConstants.PolicyEffect
does not.For instance, we add some white spaces to the
basic_model.conf
in the examples of unit tests, as shown below.Then the expression of policy effect cannot be matched, which throws an exception.
If it's an unexpected behavior, I would like to solve it soon.
The text was updated successfully, but these errors were encountered: