Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure Pipelines CI badge, maybe deprecate others in future #32

Closed
hsluoyz opened this issue Jun 11, 2020 · 8 comments · Fixed by #35
Closed

Add Azure Pipelines CI badge, maybe deprecate others in future #32

hsluoyz opened this issue Jun 11, 2020 · 8 comments · Fixed by #35
Assignees
Labels
enhancement Enhancement the exist feature

Comments

@hsluoyz
Copy link
Member

hsluoyz commented Jun 11, 2020

We know .NET is from Microsoft. Azure Pipelines is also from Microsoft. So using Azure Pipelines as our CI will show strong credit that our code is well tested.

Moreover, our evaluator is also using it: https://github.com/davideicardi/DynamicExpresso

image

So we should add a CI badge for Azure Pipelines. Maybe other CI badges will be deprecated in future.

@hsluoyz hsluoyz self-assigned this Jun 11, 2020
@hsluoyz hsluoyz added the enhancement Enhancement the exist feature label Jun 11, 2020
@hsluoyz
Copy link
Member Author

hsluoyz commented Jun 11, 2020

@huazhikui @nodece @xcaptain @sagilio can anyone take this issue?

@hsluoyz hsluoyz added the help wanted Extra attention is needed label Jun 11, 2020
@sagilio
Copy link
Member

sagilio commented Jun 11, 2020

I can do it, but I need permission to visit the Azure DevOps. You can use Sagilio@outlook.com to invite me at Azure DevOps.

@huazhikui
Copy link
Member

huazhikui commented Jun 11, 2020

one month ago, I has added Microsoft. Azure Pipelines ,but i have not add the CI badge @sagilio @hsluoyz
https://dev.azure.com/Casbin/Casbin.NET/_build?view=pipelines

@hsluoyz
Copy link
Member Author

hsluoyz commented Jun 11, 2020

@huazhikui great news to hear!

@sagilio can you make a PR to add the badge for: https://dev.azure.com/Casbin/Casbin.NET/_build?view=pipelines ?

@hsluoyz
Copy link
Member Author

hsluoyz commented Jun 11, 2020

@sagilio you can also remove Appveyor totally in the new PR.

@sagilio
Copy link
Member

sagilio commented Jun 11, 2020

@sagilio you can also remove Appveyor totally in the new PR.

We need Appveyor to provide Coverage Status now.

@hsluoyz
Copy link
Member Author

hsluoyz commented Jun 11, 2020

OK. Then we only add the Azure Pipelines badge for now.

@hsluoyz
Copy link
Member Author

hsluoyz commented Jun 14, 2020

one month ago, I has added Microsoft. Azure Pipelines ,but i have not add the CI badge @sagilio @hsluoyz
https://dev.azure.com/Casbin/Casbin.NET/_build?view=pipelines

@huazhikui can you add my Microsoft account: hsluoyz@163.com to the admin of the Casbin org in DevOps? https://dev.azure.com/Casbin/

image

sagilio pushed a commit to sagilio/Casbin.NET that referenced this issue Aug 19, 2023
Signed-off-by: Tan <2912363476@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement the exist feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants