Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add full support for sync api. #148

Closed
wants to merge 4 commits into from
Closed

feat: add full support for sync api. #148

wants to merge 4 commits into from

Conversation

Zxilly
Copy link
Contributor

@Zxilly Zxilly commented Aug 8, 2021

No description provided.

Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
@Zxilly Zxilly requested review from hsluoyz and nodece August 8, 2021 10:53
@coveralls
Copy link

coveralls commented Aug 8, 2021

Pull Request Test Coverage Report for Build 1109906351

  • 152 of 266 (57.14%) changed or added relevant lines in 12 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-3.4%) to 73.191%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model/model.ts 3 4 75.0%
src/coreEnforcer.ts 7 10 70.0%
src/rbac/defaultSyncedRoleManager.ts 2 11 18.18%
src/rbac/internalRoleManager.ts 108 122 88.52%
src/util/builtinOperators.ts 9 26 34.62%
src/syncedEnforcer.ts 5 75 6.67%
Files with Coverage Reduction New Missed Lines %
src/internalEnforcer.ts 1 57.87%
src/enforcer.ts 4 91.86%
Totals Coverage Status
Change from base Build 1107690622: -3.4%
Covered Lines: 1211
Relevant Lines: 1589

💛 - Coveralls

@hsluoyz
Copy link
Member

hsluoyz commented Aug 8, 2021

@Zxilly don't append "Revert: xxx" commit, just override the git history:

image

@Zxilly
Copy link
Contributor Author

Zxilly commented Aug 9, 2021

It's impossilbe to make async function works like sync.

@Zxilly Zxilly closed this Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants