-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain enforcement in log #425
Conversation
I think logs are not very friendly for users. They want to return matched rules:
Can we add a function called |
what do you think of changing the signature of
or
otherwise we need to split |
Thanks @dovics , Must approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hsluoyz Is there any progress? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉 This PR is included in version 2.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
For #355
Explain why an enforcement was or wasn't satisfied.Controlled by
autoExplain
in enforce,Print the policy related to the result to the log.such as
some(where (p.eft == allow))
, the explanation will be all allowed policy.whether it hits depends on user selected effect. User can modify it by interface EffectorEx