Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add server-side pagination for Tokens and Records pages #312

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

seriouszyx
Copy link
Contributor

@seriouszyx seriouszyx commented Oct 30, 2021

@casbin-bot
Copy link
Contributor

@tangyang9464 please review

@hsluoyz
Copy link
Member

hsluoyz commented Oct 30, 2021

@seriouszyx can you provide a live demo link? (like in your server and your domain)

@seriouszyx
Copy link
Contributor Author

@hsluoyz
Copy link
Member

hsluoyz commented Oct 30, 2021

@seriouszyx it looks great! Can you also add this pagination to 5 other pages as:

image

Also, can you support the original non-pagination mode? Like if p and pageSize are not provided, it still fetches all rows by default.

@seriouszyx
Copy link
Contributor Author

@hsluoyz OK!

Signed-off-by: “seriouszyx” <seriouszyx@foxmail.com>
@seriouszyx
Copy link
Contributor Author

@hsluoyz
Copy link
Member

hsluoyz commented Nov 6, 2021

lgtm!

@hsluoyz hsluoyz merged commit b1db47b into casdoor:master Nov 6, 2021
@casbin-bot
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@seriouszyx seriouszyx deleted the issue-268 branch February 20, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add server-side pagination for "Tokens" and "Records" pages
3 participants